Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3913059ybe; Mon, 16 Sep 2019 03:34:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJt3FpS4KQE75ntRC7HSq63PTy5Kk8M4hUmW8dQSyMEstAjkuZsoB2Yo9xOvGPG7ixUDZQ X-Received: by 2002:a50:eac3:: with SMTP id u3mr10971864edp.9.1568630081504; Mon, 16 Sep 2019 03:34:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568630081; cv=none; d=google.com; s=arc-20160816; b=ep8Dag+tPo2PM0HDF+KxJVFKwXXEi4hdKAygkvY/yP/8Rn9twaKxZTGpvuIANTBDXC Z3TcQkQr8Rhrmp+kehqLGzt8jSxqCgxFVR5ahbP0ZdIMf/mEXc91UxbuLFGJAyxZW2Tr KMKvfPpfB0gIo2PFsBPIZvzHAx4/WXixCNrPikZ/fWwyEFYNYkS346Ida+tTwpYZQJ2W 4P0j5PgDreJvijBafVragaafogBkMgf4M+U4CHIQKEfvcp/bYQcNzoH9fL+lNT6AbDto IYMbyi1ET4NSurim8tAxti2Rz88ZQ1pAHLfgJnWUtcoA6k4mi6Nl+ZF5Oh266KCWsFDA YYCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=RHbI26jBxHHVdC5MVSVSZ4FBgEGe0bhj06FcnSvvAak=; b=gRgHf8GFt+b3F4D0HscHWTDqgy+RaDybn32N0puLSNWCO1t+ptLIlFpAY2i2NXT47y Qpy96FWMw/dmGApX88QADb+MNsbVe4s/lgIWaENraemCU5rClkOPrugdFL3FteUB/ULd Q8prLEgc0CtnZWsjrlfAnKhcTgFL3zMXIDvlBdmBAoymNlA6flsepr6iyKnqK87y+pDl DvL709G9e+p5TIdXMTxBQH7mWZsuFinJOIvzUufZ0PO9TGDeB4UEhjC8ds3xjPO+8uTD aCqbVFH2BAFUoyt8WXi+AblDnvbpL8NENGT4RsDNuHElJbhO5i+WCcaVzkN6VF38pqAN W9RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=DiAf2dDQ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4si11538579edr.377.2019.09.16.03.34.04; Mon, 16 Sep 2019 03:34:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=DiAf2dDQ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731054AbfIPIcc (ORCPT + 99 others); Mon, 16 Sep 2019 04:32:32 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38038 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731049AbfIPIcc (ORCPT ); Mon, 16 Sep 2019 04:32:32 -0400 Received: by mail-wr1-f68.google.com with SMTP id l11so37840426wrx.5 for ; Mon, 16 Sep 2019 01:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RHbI26jBxHHVdC5MVSVSZ4FBgEGe0bhj06FcnSvvAak=; b=DiAf2dDQwonEc0dwP6bV3KOIvQwSWBgMxY+xlRd8eBvVwiAUqKOLEEQjyiKpg2ohac x37nvAHU1y5neDSKKO5JTG+KcqfqyPGr2o0TfE+fONNOoPhT7SM2V4+9wLNsFULgjcuf OrUtWcUSIXWbjGpe0zAIbzqvgymDA5Af6lQUw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RHbI26jBxHHVdC5MVSVSZ4FBgEGe0bhj06FcnSvvAak=; b=UitD8Jxzm6j9lZR1o/vOqdEJc2H9ZcYLD7I+f1PuKomlqsglM3fhhSKws+ct7Xtk6z Lu1SRb1A3aYDJ5hPMtyOABTIGqt+4LIkZI7nmDSSb368N00EpnPc7hvCCxo1tx6jAroZ +MT1mAOvCG7ctErJ2YveZciePRwgtOKyOFZddpfG6iO9Tap6vDYtS8DT4Q7HjQ9lYU/A rFSWgM+UxEKju4aLqCvbFuKsijw+E6Vw6UgVLFsnYj1eg1582k1r3Hm93ZZeMl8KmSrc qiH4w4QWr5bkint8pH/K+2BdZU9pg6x5pIWLaiPHCNoe66R5d4NszVOmdXlUa4cerBJD 3Drw== X-Gm-Message-State: APjAAAVXlhyOzOfx6DycpRDpO7Tmhly8T44abGY7fLYCVxhfhyGTNK+P boESWKRw2sAHtrEgdmbWDQu3tw== X-Received: by 2002:adf:ff8a:: with SMTP id j10mr51465080wrr.334.1568622750499; Mon, 16 Sep 2019 01:32:30 -0700 (PDT) Received: from [10.176.68.244] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id a205sm23587277wmd.44.2019.09.16.01.32.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Sep 2019 01:32:29 -0700 (PDT) Subject: Re: [PATCH] brcmsmac: remove a useless test To: Christophe JAILLET , franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, kvalo@codeaurora.org, davem@davemloft.net Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20190915193210.27357-1-christophe.jaillet@wanadoo.fr> From: Arend Van Spriel Message-ID: Date: Mon, 16 Sep 2019 10:32:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190915193210.27357-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 9/15/2019 9:32 PM, Christophe JAILLET wrote: > 'pih' is known to be non-NULL at this point, so the test can be removed. Acked-by: Arend van Spriel > Signed-off-by: Christophe JAILLET > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)