Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D5E73611CE
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Tom Psyborg <pozega.tomislav@gmail.com>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: use ath10k_pci_soc_ functions for all warm_reset instances
References: <1564305118-3059-1-git-send-email-pozega.tomislav@gmail.com>
        <20190917141014.6A1DA602F3@smtp.codeaurora.org>
        <CAKR_QVKtLM7fWs94y_KqndSXmUNTVHO7xqBK3sr5M44DSO_K0g@mail.gmail.com>
Date:   Tue, 17 Sep 2019 20:30:24 +0300
In-Reply-To: <CAKR_QVKtLM7fWs94y_KqndSXmUNTVHO7xqBK3sr5M44DSO_K0g@mail.gmail.com>
        (Tom Psyborg's message of "Tue, 17 Sep 2019 18:54:07 +0200")
Message-ID: <87a7b2bzkf.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Tom Psyborg <pozega.tomislav@gmail.com> writes:

> On 17/09/2019, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Tomislav Po=C5=BEega wrote:
>>
>>> Use ath10k_pci_soc_read32 / ath10k_pci_soc_write32 functions for
>>> the rest of warm_reset functions. Until now these have been used
>>> only for ath10k_pci_warm_reset_si0, but since they already exist
>>> it makes sense to simplify code a bit.
>>> Runtime tested with QCA9862.
>>>
>>> Signed-off-by: Tomislav Po=C5=BEega <pozega.tomislav@gmail.com>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
> is this a typo or should've I add your SoB line to that commit?

This is just because of my pwcli patchwork script and it's stgit mode.
It takes the commit log directly from the pending branch, where I need
to add my s-o-b as I publish the branch.

In general you should only add your own s-o-b line:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign=
-your-work-the-developer-s-certificate-of-origin

> btw what about this patch it's been sent out quite a several months
> ago? https://patchwork.kernel.org/patch/10860301/

I have not looked at that yet but it's in my queue.

--=20
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes