Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp6626771ybe; Wed, 18 Sep 2019 06:37:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqyv3kEgEAwciCnmxo9PAsPAIrhlG78VzHTw29VGRqIkOnvI24tgCPCawVfoyPrctbNn/ugL X-Received: by 2002:a05:6402:614:: with SMTP id n20mr10339406edv.237.1568813845462; Wed, 18 Sep 2019 06:37:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568813845; cv=none; d=google.com; s=arc-20160816; b=Cn4gGJlPTgEdVju5m+eaZ64xGcmJhBFNuIz91kl7DuuQkeIkzUUAN4hxrt7TLKpeRO j10Kl9VsoNxuDjfikNkU3y2whKJGiZAYcIC89XvIqY2kNNAzBIUWjHJ8csfjoYcE8l2j /WTgIOwhUEQRxgA4h/yaWN5YMgd08KQPap2MdI70yBO5IWe9WMgWwcPt8T8RIGxjlTrQ uDqxlg7VDIIOq9Q5Dmq7FradUz0X/TX4bzgJMfLvVoAtDUsLtQlJ97jmDcqcW3ono4HK XBNWNbnDhfDGVIunsDR4LPHegKvZWNJL4le4USp76HwjuONdDCPeHw7DbSlSPiVV2hhP E9ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=LaWfQ1u2QufmSgjL6Vt41vrPzpsrs8pvePW5k/CXWNU=; b=HQNnPj6gWXm4q2Ghm62rAyxd2Vi2fsxCilCaMiBaRTv2u7A+DAeA1flu5eMhpaNr/s 50YliuPGYiRcQwPvFi5vayinvT9F9bNaPS4TxeSpJPDI63WhEQP4C1S1TFVlRxC8NT62 l4p63hPeZPykbH8xNRHPbmVhNQr5MKqbvvWF+bsq21sPVP2sGrnt29lMCq3f1B7w6dMl a4RR7LnQOMks9sCtJNp9f5ukEIzVWTB258I8+sAKSqjVRydwXspGHr7SpGQM9mlk2Srm tZBr0M/f3/u6hzy6a1UcjD934Q8WwQKs0CMBaWknBxCfmJ5km/yjSkyybAEcJpPHqe0E urcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=FZQShb2K; dkim=pass header.i=@codeaurora.org header.s=default header.b=ET8E4D+x; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8si2826289ejd.270.2019.09.18.06.36.59; Wed, 18 Sep 2019 06:37:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=FZQShb2K; dkim=pass header.i=@codeaurora.org header.s=default header.b=ET8E4D+x; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731549AbfIRNI5 (ORCPT + 99 others); Wed, 18 Sep 2019 09:08:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39962 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729261AbfIRNI5 (ORCPT ); Wed, 18 Sep 2019 09:08:57 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1ABCD6155D; Wed, 18 Sep 2019 13:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568812137; bh=Xlm9buTwkjGMeOAaB1iCCifyWmGXMZvazAeI3ceUL+U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FZQShb2KcdByFxaca4AVvz7XWHjldvgGlJlQzoh8flyuU74TrUd7yCsv6eR3teZR8 Wjze0C+teQYY8fqNlMRPIvgnaJJhLDuMlx1fLgyZwIgVJ+el2clRsdkz3yC3tC2JpA OyaRaQMaqitXo5SJcCUjS9+dXoUxFkeHi+zy/KOY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F129F614DC; Wed, 18 Sep 2019 13:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568812136; bh=Xlm9buTwkjGMeOAaB1iCCifyWmGXMZvazAeI3ceUL+U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ET8E4D+xHsJ5/aDa1J5+s0ESTYpL0JpbVSbrOQsbAvaQihdaGD18ntRHyCmOq6y29 UyK39hb8V64zMYu05Nx8wF+P20TxsoGiavH3XA7lr83pJ2/8egpH1RtSaEjlJ5t0R0 jVbwPwSgzIlRRPeD+hjQSSW81/J7ASldW4mD/6LM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F129F614DC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Mao Wenan Cc: , , , , , , , , Subject: Re: [PATCH net] iwlwifi: add dependency of THERMAL with IWLMVM References: <20190918122815.155657-1-maowenan@huawei.com> Date: Wed, 18 Sep 2019 16:08:51 +0300 In-Reply-To: <20190918122815.155657-1-maowenan@huawei.com> (Mao Wenan's message of "Wed, 18 Sep 2019 20:28:15 +0800") Message-ID: <875zlpbvks.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Mao Wenan writes: > If CONFIG_IWLMVM=y, CONFIG_THERMAL=n, below error can be found: > drivers/net/wireless/intel/iwlwifi/mvm/fw.o: In function `iwl_mvm_up': > fw.c:(.text+0x2c26): undefined reference to `iwl_mvm_send_temp_report_ths_cmd' > make: *** [vmlinux] Error 1 > > After commit 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal > monitoring regardless of CONFIG_THERMAL"), iwl_mvm_up() > calls iwl_mvm_send_temp_report_ths_cmd(), but this function > is under CONFIG_THERMAL, which is depended on CONFIG_THERMAL. > > Fixes: 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal monitoring regardless of CONFIG_THERMAL") > Signed-off-by: Mao Wenan Luca, should I apply this directly to wireless-drivers? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches