Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1495142ybj; Fri, 20 Sep 2019 11:25:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxVGx5nk6uwN/u8ya9+Gf9tcD78MQ56rCNp4t3+vO1i41hywXYdXK1oYO/U60aL8wI1PSiJ X-Received: by 2002:a17:906:d185:: with SMTP id c5mr20007907ejz.139.1569003937257; Fri, 20 Sep 2019 11:25:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569003937; cv=none; d=google.com; s=arc-20160816; b=tOStfJkFnxxuahOorIx5h+fzLt5ZH4DBR2amFpSkY2oMfqEMUOEdZSb6FpU/eZv7f4 zsrxUZ9XZnDLWvRi3rjcj8jHX2uRVMz76sVG4m4UfDj9fQ7plr4WunC7Od4pOTqPdI55 3u8pR3WVLpsB/iCF3Wj2mCPO/e2C/swXog6uyh/ct2q37UpCSIHMdbR182LYe6uRVyPZ 7l2JIZHjUU+si+rTzuJB2pqMGv5RXD5DaoLbqqC7CytGPknfxzLjEME4RbYCmuFUQ7S0 G1TUhduDHfqtAloRXBmZu2vuGxwHMow1sT3U7mrkaEM7Vym3163SC+i4QAEXlPH81kXx Garw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=IaghVoflLOVqTena3A7p4l9xD5l+q9kh6T9RxG/plt8=; b=0gIz1j6miXvDhrJlU+Ea4wtRYClAwOn+hQdovYStU/NofGb61K6gMHX4KV60OJAm1I nY52++ut+bZsGCxflHhCMAAU0SQUNKJx+UGKMTxEpeZ3RbVcUKD71NdWbM3DI9T9SwIY RI0a6ijRvNCLfQNSTVL6ALda4IRDSIHy00XQ7oXA87K22MKh/WmZNK9N7fCGz/0R+oiI Qh9HcOn3F+eYgOAEzQMlBZ7XfPmvtHRh/zuo+yRpbxu/TURmmQCpUexikOVXkwTNby8g g543A75aJqCy1n9NqGavAL1mPXxrv8AkD6fTKyg+fxdyBfW3vNZCHxb+XnsAwgL3GL55 rWeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=LVjTzk8F; dkim=pass header.i=@codeaurora.org header.s=default header.b=E+VhMKLo; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4si1496424ejd.328.2019.09.20.11.25.12; Fri, 20 Sep 2019 11:25:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=LVjTzk8F; dkim=pass header.i=@codeaurora.org header.s=default header.b=E+VhMKLo; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437564AbfITIfy (ORCPT + 99 others); Fri, 20 Sep 2019 04:35:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59122 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437539AbfITIfy (ORCPT ); Fri, 20 Sep 2019 04:35:54 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 46CBD61418; Fri, 20 Sep 2019 08:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568968553; bh=RCIs686ZCd5SY5O9P5Obm5ejnNuCSq2iYbDI5mpFAro=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LVjTzk8FwvUoGLFtMzI0JMpNAFd/L+kmHdfE+KkWMkgagNT+hEtGYlPkgmVRlg5Yv hldBwI+P2nJ1wfeOT9nLgbHuPr6xtclsgqv0RtaRhgDazSmKOcUwJyjLc+4ei/0obY StVPJ/lrI8Ml6PxU0TKq2uh9k30Zh7to/RnRD8rw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from x230.qca.qualcomm.com (37-136-106-186.rev.dnainternet.fi [37.136.106.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A270960452; Fri, 20 Sep 2019 08:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568968552; bh=RCIs686ZCd5SY5O9P5Obm5ejnNuCSq2iYbDI5mpFAro=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=E+VhMKLoStQuTMcONfLx6bKI8BrZvmArCkiTFhg9zqR4+LLKZUwugKQ4Psct5xqke gpCtjM1l7jzT0xmpHSbF2p0rIYUB7IEn/akEdSY/TeBXnZ9lZs7GaFlcACAASu9+3R q99p5HW0OIouMVuuEyzNIF4EpQ0g0RzNKA07st68= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A270960452 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Tony Chuang Cc: Brian Norris , linux-wireless Subject: Re: [PATCH 05/15] rtw88: pci: release tx skbs DMAed when stop References: <1568617425-28062-1-git-send-email-yhchuang@realtek.com> <1568617425-28062-6-git-send-email-yhchuang@realtek.com> <87tv97ctsp.fsf@codeaurora.org> Date: Fri, 20 Sep 2019 11:35:48 +0300 In-Reply-To: (Tony Chuang's message of "Fri, 20 Sep 2019 08:29:15 +0000") Message-ID: <87lfujcql7.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tony Chuang writes: >> > I wonder if, given the problems I've seen (the driver can become >> > totally ineroperable), this patch and the previous patch (its only >> > real dependency) should be fast-tracked to the current release. >> >> I agree, this sounds like a serious problem. So I'm planning to queue >> patches 4 and 5 to v5.4, if it's ok for Tony. > > It's OK for me, didn't realize that this is a serious problem, so I missed it. > Also if possible you should queue patch 2, that reordering will cause > two H2C skbs not be released because HCI hasn't started, everytime > enter/leave IDLE state (rtw_power_[on|off]). > > Should I resend and add a v5.4 prefix or something? No need to resend, I'll try to apply patches 2, 4 and 5 as is and will let you know if there are any problems. -- Kalle Valo