Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 416EE60240
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Tomislav =?utf-8?Q?Po=C5=BEega?= <pozega.tomislav@gmail.com>
Cc:     linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 5/5] ath10k: pull_svc_rdy code-style fix
References: <1569268165-1639-1-git-send-email-pozega.tomislav@gmail.com>
        <1569268165-1639-5-git-send-email-pozega.tomislav@gmail.com>
Date:   Tue, 24 Sep 2019 08:30:19 +0300
In-Reply-To: <1569268165-1639-5-git-send-email-pozega.tomislav@gmail.com>
        ("Tomislav \=\?utf-8\?Q\?Po\=C5\=BEega\=22's\?\= message of "Mon, 23 Sep 2019
 21:49:25 +0200")
Message-ID: <87d0fq5kic.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Tomislav Po=C5=BEega <pozega.tomislav@gmail.com> writes:

> Drop unneeded lines by moving skb data in both main and 10x WMI
> pull service ready event operations.
>
> Signed-off-by: Tomislav Po=C5=BEega <pozega.tomislav@gmail.com>
> ---
>  drivers/net/wireless/ath/ath10k/wmi.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless=
/ath/ath10k/wmi.c
> index 59d2d2a..8ab178c 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -5345,13 +5345,12 @@ static int ath10k_wmi_alloc_host_mem(struct ath10=
k *ar, u32 req_id,
>  ath10k_wmi_main_op_pull_svc_rdy_ev(struct ath10k *ar, struct sk_buff *sk=
b,
>  				   struct wmi_svc_rdy_ev_arg *arg)
>  {
> -	struct wmi_service_ready_event *ev;
> +	struct wmi_service_ready_event *ev =3D (void *)skb->data;
>  	size_t i, n;
>=20=20
>  	if (skb->len < sizeof(*ev))
>  		return -EPROTO;
>=20=20
> -	ev =3D (void *)skb->data;

Actually I prefer the original style, so that we first check the data in
skb is valid and only then assign the data to ev.

--=20
Kalle Valo