Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <a87917de-d60c-b746-742a-ade37ffe9c4c@candelatech.com>
References: <1553025580-6118-1-git-send-email-pozega.tomislav@gmail.com>
 <2715bcef-5b03-fc19-e665-3c6f90a7d123@candelatech.com> <CAKR_QVKfb5vkT1xmmEyvJzeb+VnPx8T3ZpkdLPTMx+agtSBYMg@mail.gmail.com>
 <a87917de-d60c-b746-742a-ade37ffe9c4c@candelatech.com>
From:   Tom Psyborg <pozega.tomislav@gmail.com>
Date:   Wed, 25 Sep 2019 12:35:05 +0200
Message-ID: <CAKR_QV+TDi5DQ5Vsc-nactAryzAExe470VNJ+tj+vUa37rs_Xg@mail.gmail.com>
Subject: Re: [PATCH] ath10k: Fix ASPM L1 state on QCA988X
To:     kvalo@codeaurora.org
Cc:     linux-wireless@vger.kernel.org,
        Ben Greear <greearb@candelatech.com>,
        Sujith Manoharan <c_manoha@qca.qualcomm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi

Some more info: the actual regression was introduced with the commit:
ath10k: enable ASPM - reverting this change only is enough to have
card operating as expected.

Still, this patch would apply, but in slightly different manner.

On OpenWrt router, masked value would always read 0x27 with two cards
tested QCA9862 and QCA9880 v1.

But on HP laptop, QCA9862 masked value reading was 0x0f, and writing
0x27 to this register still seems fine, as long as the faulty ASPM
change is kept reverted.

I did also notice about 10=C2=B0C temperature drop in ath10k_hwmon and no
more crashes when resuming from sleep, but that might be related to
the fact these tests were now done with backports-5.1 instead of the
in-tree 4.9 driver.