Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1833954ybn; Thu, 26 Sep 2019 02:57:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwM+CXKOTo7yoDsFTLvnXI70MpEdjgqBd+zwW3A//GStsfYfTYAbhxBYWbEfHJ9JzEa/XyR X-Received: by 2002:a17:906:20c7:: with SMTP id c7mr2193877ejc.248.1569491854939; Thu, 26 Sep 2019 02:57:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569491854; cv=none; d=google.com; s=arc-20160816; b=XRInL8T2n5x3V4vVgtxC5T88+K4zNqYBCswL57GvSwkJfWzAFjPQv6jwwCdGUPisxk KxrJx7h3U0n2wrPNdeWcNuXJGiPJ0buT122LzPNoK1uDb5F6F3p0G3OltdwBloC72hbf KnB5dgN7jGs0k6ncbp4TgMHqVxVft/+zY36QcypqKpoGCfpaweCdRttY5WUU45Y+hqUp LiIYVx7IuHU5xNYna7pEd64R6m3u9Xi+Op/EziFHWzivMcOor3rE7FOb2ObCipa/FPuu nvBaG+IrYWw4nH1hqnRgWuV1DcEnTm/0An+udfj8cmsSzhAhwFruZqjib+CF2Bvs8k+u beNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=26gn2NTMQ9dZ0K5OTw06VLKtRMQYca/TvxMBDgiM3Gc=; b=JaqGWaofkSVbp6kLJz8uiVe+WTGCl9pZZ0H0lUN89IQZLAuwzE3cKiU50Csyf5MvUU 0P4yuZzXPGMT1L0yAqRquDX/nezZ/FKG+waAFF9c2HacndfN1xt0+vgjziAnpgqkF5p/ LcO9aA4uzUYYfYd6DCvAxJaqWXXUKxxBDBHCWEn30n+mXXrEQPXRn2XT7Gm33eNm3e6N sWZfZJ5lxQk5e7/QVfFJtfAZ8wVqGRFIt9Y9b0mZIJ2xKzJz/xSqAj/4+NXn3aupO5lp hUukzBVmjaeejoU0jKBY6R5p9pL+Vs3s9bTjyan7R9X8ULO7JJbmkglD71HWJDwQMfjR Bfiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f21si991785eda.216.2019.09.26.02.57.10; Thu, 26 Sep 2019 02:57:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393352AbfIYUto (ORCPT + 99 others); Wed, 25 Sep 2019 16:49:44 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53454 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728993AbfIYUtn (ORCPT ); Wed, 25 Sep 2019 16:49:43 -0400 Received: by mail-wm1-f68.google.com with SMTP id i16so186800wmd.3; Wed, 25 Sep 2019 13:49:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=26gn2NTMQ9dZ0K5OTw06VLKtRMQYca/TvxMBDgiM3Gc=; b=sPxydplJQsLnQ+7EyrubEvK9CQs1bIJ8yiz1tgKnOfz3XtugwaJfHbdXuo4wkgVf2r Qt9hkrmcm7B444jVh+rSHPCWoGjWY9jXz9Z2Jp7mmXYW2YGvTow8g3qV2irlWTznB1KA UgYrWxPokB6ZEfyTv145LbJ499QCuttxOCkjrAPTCRz0bloKgwit8+AlNkSSbT8xTucu NqjnDwYpQ4liQJhbbZrYCXcmVMyP+b2vOpR43C0le7JXcFMgzzpekW9s1IvtphnUx/Yj UZZzZ4VAKKPshbnjGh8qZBuUiu46mmCE7JSngpHkN2MJ8s2E0k153s4ZTACweV6b/X6l dnbA== X-Gm-Message-State: APjAAAVX4GxVDIq284+ygr8lPwJ0V11Ykbf1UpeAWi1ounVVX0XsMzoB Pb3BCz5wdArZcGtwYOysx8Y= X-Received: by 2002:a1c:cb05:: with SMTP id b5mr94727wmg.79.1569444580810; Wed, 25 Sep 2019 13:49:40 -0700 (PDT) Received: from localhost.localdomain (99-48-196-88.sta.estpak.ee. [88.196.48.99]) by smtp.googlemail.com with ESMTPSA id z1sm364705wre.40.2019.09.25.13.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 13:49:40 -0700 (PDT) From: Denis Efremov To: Kalle Valo Cc: Denis Efremov , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iwlwifi: dvm: excessive if in rs_bt_update_lq() Date: Wed, 25 Sep 2019 23:49:35 +0300 Message-Id: <20190925204935.27118-1-efremov@linux.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There is no need to check 'priv->bt_ant_couple_ok' twice in rs_bt_update_lq(). The second check is always true. Thus, the expression can be simplified. Signed-off-by: Denis Efremov --- drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c index 74229fcb63a9..226165db7dfd 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c @@ -851,7 +851,7 @@ static void rs_bt_update_lq(struct iwl_priv *priv, struct iwl_rxon_context *ctx, * Is there a need to switch between * full concurrency and 3-wire? */ - if (priv->bt_ci_compliance && priv->bt_ant_couple_ok) + if (priv->bt_ci_compliance) full_concurrent = true; else full_concurrent = false; -- 2.21.0