Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1869451ybn; Thu, 26 Sep 2019 03:30:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqyIK+NnFOc3WmNXGcTtjMtXm4dI760qGo6x5lxDhN1K7VdT0Fklix73MLDwRj3+kh0pCKGn X-Received: by 2002:a50:95c1:: with SMTP id x1mr2677490eda.180.1569493804406; Thu, 26 Sep 2019 03:30:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569493804; cv=none; d=google.com; s=arc-20160816; b=gZW4l0EzKEkAI/s7RS12rabHyxEDCsskoDWmPslox1TKSt5gXJSJ9Gy74TuJdEPRMy hWHhLr0C+q2ktogZ874HFdqFPF4GfEgx75s/zMVH5IVsHDArEIQgRDgjqV4+BTfoi2dD GGizTDFegfzjlDg81aiuRHE19C8oWexuD8Eon7LI9ugQuYNVnpwwakTCuqnB5ish91NO 7zXJTmFnAPMnS+Fxr0tR5bDDDVgbLWxWdI6csz/Y99/bpFOuyBVD+oEq8zpMnA9cucyd Hz6m/QFWl4R5QZkcuU0fEPO5vq1mayFKa2R6aTp0dpnj3GYqBEHDPtEsYjfPlYdw07KG xhQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:to:from:dkim-signature; bh=oLhuyy/DtavGkEfRLPcjnd5dK1Vu/owMwFxBjpIOBos=; b=N918q5u7Fi3qVDm5dnPaqy1y9vH0lI4sgmxo5KM997tfX3awVgpzUaPgvIdCGcIpmN imLPWqDVXhlwTo9Ca5OlvFbGwuy8anVCNhsDT695PNtfQjpxOFbVyifW06gvrjy6mgZL NGhoSGME5JzVCclpMQcjZErym50rmgbWBt+c694BUV69h4bHelUk9GxgRwWEBdr2L3bI x9zjoRrbEjqpG5tcUVCRuX8keWbU7h5O12w296qz7eMgK1NxXt1NZe55lEsoksmv10JF sYM4Kd6zIsL3nmaHykOTFwPyfCp2Z79retjDz/ZiD+lr6H5yCtweKJKuzaEpmacnhE79 MqxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=OIQu9R3F; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o25si687263ejc.361.2019.09.26.03.29.39; Thu, 26 Sep 2019 03:30:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=OIQu9R3F; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729990AbfIZJFb (ORCPT + 99 others); Thu, 26 Sep 2019 05:05:31 -0400 Received: from nbd.name ([46.4.11.11]:53296 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729122AbfIZJFb (ORCPT ); Thu, 26 Sep 2019 05:05:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=References:In-Reply-To:Message-Id:Date:Subject:To:From:Sender: Reply-To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oLhuyy/DtavGkEfRLPcjnd5dK1Vu/owMwFxBjpIOBos=; b=OIQu9R3FrGeaPvRJBmP5TFouK+ zedSflQCX7S3tpjcX4IjB4yOyiiIrEkRhGbk5hmyrRIeYmPy0ZZipMm8sj72YpAJvRC6T5XYcgwuN vTvM0gjRTtzrjh4kY6Za6r/sQGZ8OOsFyBjv08EshvUuKop+6ohN8j6PZ/YL2br/mMXA=; Received: from p54ae9b80.dip0.t-ipconnect.de ([84.174.155.128] helo=maeck.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDPiL-0008Sp-MC for linux-wireless@vger.kernel.org; Thu, 26 Sep 2019 11:05:29 +0200 Received: by maeck.local (Postfix, from userid 501) id 3B5E06997D47; Thu, 26 Sep 2019 11:05:23 +0200 (CEST) From: Felix Fietkau To: linux-wireless@vger.kernel.org Subject: [PATCH 3/3] mt76: use cancel_delayed_work_sync in mt76_rx_aggr_shutdown Date: Thu, 26 Sep 2019 11:05:23 +0200 Message-Id: <20190926090523.68392-3-nbd@nbd.name> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20190926090523.68392-1-nbd@nbd.name> References: <20190926090523.68392-1-nbd@nbd.name> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The workqueue item needs to be fully shut down before the struct can be freed. Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/agg-rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c index 8f3d36a15e17..2276fd4e9ec3 100644 --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c @@ -257,7 +257,7 @@ static void mt76_rx_aggr_shutdown(struct mt76_dev *dev, struct mt76_rx_tid *tid) u8 size = tid->size; int i; - cancel_delayed_work(&tid->reorder_work); + cancel_delayed_work_sync(&tid->reorder_work); spin_lock_bh(&tid->lock); -- 2.17.0