Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 10/15] mt76: mt76x02: track approximate tx airtime for airtime fairness and survey
In-Reply-To: <27bb95dd-1f0e-5862-3616-04452808e736@nbd.name>
References: <20190926174732.42375-1-nbd@nbd.name> <20190926174732.42375-10-nbd@nbd.name> <871rw218ty.fsf@toke.dk> <2475938e-b82c-9924-f7db-f475ec2530b3@nbd.name> <87sgoiyw0p.fsf@toke.dk> <27bb95dd-1f0e-5862-3616-04452808e736@nbd.name>
Date:   Fri, 27 Sep 2019 11:07:12 +0200
Message-ID: <87mueqyunz.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Felix Fietkau <nbd@nbd.name> writes:

> On 2019-09-27 10:37, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> Felix Fietkau <nbd@nbd.name> writes:
>>=20
>>> On 2019-09-27 09:45, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>>>> Felix Fietkau <nbd@nbd.name> writes:
>>>>=20
>>>>> Estimate by calculating duration for EWMA packet size + estimated A-M=
PDU
>>>>> length on tx status events
>>>>=20
>>>> Would it make sense to move some of this code into mac80211? If we're
>>>> going to do airtime estimation for queue limiting it may make sense to
>>>> use this instead of the simplistic estimate I used in my RFC patch?
>>> Sure. I mainly put it in the driver because I wanted to get it working,
>>> tested and merged first without having to wait for a mac80211-next ->
>>> wireless-drivers-next merge.
>>=20
>> Right, OK. So that means another patch set on top of this to move it
>> afterwards? Don't suppose you can be convinced to take care of that as
>> well? :)
> I could, but I don't know when I will have time for it, since my plate
> is pretty full at the moment.

Heh, I was afraid you'd say that. That makes two of us; guess we'll see
who gets around to it first, then :)

Is there anything in your new airtime.c that is mt76-specific apart from
the struct mt76_dev and struct mt76_rx_status parameters?

-Toke