Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8052255ybn; Tue, 1 Oct 2019 02:23:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqw34sSeTxyziQUjBeKGJbYX/3a+WiJIUatxoyzQW2BNgIvZv3GLQxOLTwdHkbp8unKYb+id X-Received: by 2002:a50:eb93:: with SMTP id y19mr24165636edr.94.1569921805731; Tue, 01 Oct 2019 02:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569921805; cv=none; d=google.com; s=arc-20160816; b=LMrfGOYMeckyt8dGg2aLYMO4zJjfZ5T6+olxj91yzCL3SihDAG1dNGae1eo8WDFF/7 6vushNh48OBdxzj8/Qja0Oc7yUoviYlR1tgjA6zvgvDGcBiXMGzFYLo+dO+Hd4GeZhxa 0rC80iFgHUswHN/3SLc9u4GS4aU2NPPnzpQijRcpMluNsNSbOSYigvyjr2r7aVNdFp2a 1Y0Mjhq0uBRNOicWYvDlPtZPxdpBrrs5+4a38bvJ5kQ1/rQSdSw+Ahk/xmDmxqpWFDm6 TzZHAnhT9DgDgrq56T3Dd3vCX7K5DddBkjltvNKAmuLLwMjDKxGX7B0sX6YAT9rJsdON n1Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=UoY3atlkvD2t5fmRjxumnGzNPYUxmBZ1OMAbr2wCYz0=; b=qNlVptbUQu4bidyWjobcjOY2eH7Sixi/Zy+w45iVtmX+jnEPTDRGdm0vnBps14Erfk gS5dA2ecf1cfocXz0mwazZY11/UDRY+tJvxVL2C7qD+YdX6lH5d4MgVbW0/8tBwAQ4rS uFYfdqGKZxtOKz0CQiMLFH9AedOW7q6Y+42CwNhYrDlc3V+WqjRvLXrnJPGNm3+mKDLb ZoRWUobG4xXTOZpOCkwAHSlhhlAIlF13T0Dkxg3kKhkbaJdxNCcxFp0gV3AXA13ps1r3 ff3HdoaouJ22Tk4dZYVHJsexA0D3o2ZmH71EggzNHM6+25CNMQ4HKPVskDewyIM6rBLK FX5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=WMchxioB; dkim=pass header.i=@codeaurora.org header.s=default header.b=A+mqHiEC; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b22si9188165eda.194.2019.10.01.02.23.00; Tue, 01 Oct 2019 02:23:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=WMchxioB; dkim=pass header.i=@codeaurora.org header.s=default header.b=A+mqHiEC; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387575AbfJAJVW (ORCPT + 99 others); Tue, 1 Oct 2019 05:21:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41140 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387565AbfJAJVW (ORCPT ); Tue, 1 Oct 2019 05:21:22 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 68C2D61214; Tue, 1 Oct 2019 09:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569921680; bh=QDTFqQmt/2z8/7h6T0ElABeTmTYTi368LogpuQ3Ed9o=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=WMchxioB5TsTyX0HJ3VQ8wtJrv3iDIeDjPj0meUMrxecv23wBMeVOOPWT9rQnVkaR byR9HMsKcTaAIU7Pia4rMOShKLuiELZI9cGedu9iwhs/NjQDZaF8tT4wSXKBLLpcSm uLbUWjEvPR75apzuIRQ51zKEcNAp09XV0xHsaUog= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 94074611C5; Tue, 1 Oct 2019 09:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569921677; bh=QDTFqQmt/2z8/7h6T0ElABeTmTYTi368LogpuQ3Ed9o=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=A+mqHiECFoBiwxKN5sigk3pqJ5JkjaAxf4rifrZb7qcyb4gKZTXFD94DltMVq7UeE /HigrHCtLcimjMRDxVJVo5DxOuUDeG1d4meRJMPjk1wz3CtdBYcE8nNY7YHy+lJ4Aq RP1sSZYpftSldShvmdni20c6Ib4LKCq1i9FdzEaE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 94074611C5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: Remove excessive check in _rtl_ps_inactive_ps() From: Kalle Valo In-Reply-To: <20190925205858.30216-1-efremov@linux.com> References: <20190925205858.30216-1-efremov@linux.com> To: Denis Efremov Cc: Denis Efremov , Ping-Ke Shih , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191001092120.68C2D61214@smtp.codeaurora.org> Date: Tue, 1 Oct 2019 09:21:18 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Denis Efremov wrote: > There is no need to check "rtlhal->interface == INTF_PCI" twice in > _rtl_ps_inactive_ps(). The nested check is always true. Thus, the > expression can be simplified. > > Signed-off-by: Denis Efremov > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. a0d46f7a0fa5 rtlwifi: Remove excessive check in _rtl_ps_inactive_ps() -- https://patchwork.kernel.org/patch/11161357/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches