Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 1 Oct 2019 13:58:00 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-15?Q?Toke_H=F8iland-J=F8rgensen?= <toke@redhat.com>
cc:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>,
        Aaron Hill <aa1ronham@gmail.com>,
        Lukas Redlinger <rel+kernel@agilox.net>,
        Oleksii Shevchuk <alxchk@gmail.com>
Subject: Re: [PATCH v2] mac80211: keep BHs disabled while calling
 drv_tx_wake_queue()
In-Reply-To: <87tv8su1up.fsf@toke.dk>
Message-ID: <nycvar.YFH.7.76.1910011357470.13160@cbobk.fhfr.pm>
References: <1569928763-I3e8838c5ecad878e59d4a94eb069a90f6641461a@changeid> <87tv8su1up.fsf@toke.dk>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 1 Oct 2019, Toke Høiland-Jørgensen wrote:

> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Drivers typically expect this, as it's the case for almost all cases
> > where this is called (i.e. from the TX path). Also, the code in mac80211
> > itself (if the driver calls ieee80211_tx_dequeue()) expects this as it
> > uses this_cpu_ptr() without additional protection.
> >
> > This should fix various reports of the problem:
> > https://bugzilla.kernel.org/show_bug.cgi?id=204127
> > https://lore.kernel.org/linux-wireless/CAN5HydrWb3o_FE6A1XDnP1E+xS66d5kiEuhHfiGKkLNQokx13Q@mail.gmail.com/
> > https://lore.kernel.org/lkml/nycvar.YFH.7.76.1909111238470.473@cbobk.fhfr.pm/
> >
> > Reported-by: Jiri Kosina <jikos@kernel.org>

Reported-and-tested-by: Jiri Kosina <jkosina@suse.cz>

> > Reported-by: Aaron Hill <aa1ronham@gmail.com>
> > Reported-by: Lukas Redlinger <rel+kernel@agilox.net>
> > Reported-by: Oleksii Shevchuk <alxchk@gmail.com>
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
> Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>

Thanks,

-- 
Jiri Kosina
SUSE Labs