Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ganapathi Bhat <gbhat@marvell.com>
To:     Brian Norris <briannorris@chromium.org>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Cathy Luo" <cluo@marvell.com>, Zhiyuan Yang <yangzy@marvell.com>,
        James Cao <jcao@marvell.com>,
        Rakesh Parmar <rakeshp@marvell.com>,
        Dmitry Vyukov <dvyukov@google.com>
Subject: RE: [EXT] Re: [PATCH] mwifiex: avoid deleting uninitialized timer
 during USB cleanup
Thread-Topic: [EXT] Re: [PATCH] mwifiex: avoid deleting uninitialized timer
 during USB cleanup
Thread-Index: AQHVITclVlRHwuKWQkGkD8XYjyf/L6aaW0EAgK2u2DA=
Date:   Wed, 2 Oct 2019 14:25:53 +0000
Message-ID: <MN2PR18MB2637A80D365B8B68E8216CA0A09C0@MN2PR18MB2637.namprd18.prod.outlook.com>
References: <1560354873-17182-1-git-send-email-gbhat@marvell.com>
 <20190614011648.GA121099@google.com>
In-Reply-To: <20190614011648.GA121099@google.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 72ee15ac-a247-4474-f18e-08d747446e87
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2019 14:25:53.2486
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YHHBuFWlSP4tIPEcohOBxavjAcg43xsmP5TR23HXlffw4/J2OIJjI7xXTn/mF0UuSZCGncB5ENmtUZ3bld0hlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3149
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-02_06:2019-10-01,2019-10-02 signatures=0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Brian,

Sorry for delayed response;

> > @@ -1348,6 +1348,8 @@ static void mwifiex_usb_cleanup_tx_aggr(struct
> > mwifiex_adapter *adapter)
> >
> >  	for (idx =3D 0; idx < MWIFIEX_TX_DATA_PORT; idx++) {
> >  		port =3D &card->port[idx];
> > +		if (!port->tx_data_ep)
> > +			continue;
>=20
> It's not clear to me what this is about. Are you sure you're not just cle=
aning
> stuff up in the wrong order?
OK;=20
>=20
> >  		if (adapter->bus_aggr.enable)
> >  			while ((skb_tmp =3D
> >  				skb_dequeue(&port->tx_aggr.aggr_list)))
>=20
> ...
>=20
> > @@ -1584,7 +1580,29 @@ static void
> mwifiex_usb_submit_rem_rx_urbs(struct mwifiex_adapter *adapter)
> >  	return 0;
> >  }
> >
> > +static int mwifiex_init_usb(struct mwifiex_adapter *adapter) {
> > +	struct usb_card_rec *card =3D (struct usb_card_rec *)adapter->card;
> > +	int ret =3D 0;
> > +
> > +	if (card->usb_boot_state =3D=3D USB8XXX_FW_DNLD)
> > +		return 0;
>=20
> This looks wrong. You don't want to skip your basic initialization just b=
ecause
> firmware isn't loaded yet. In fact, init_if() always gets called before F=
W init,
> so haven't you basically stubbed out this function most of the time?

I think, we are not skipping the basic initialization:
original flow:
PID_1: mwifiex_usb_probe  >>> "do driver initialization" >>> "download the =
firmware"
PID_2: mwifiex_usb_probe  >>> "do driver initialization" >>> "do interface =
initialization" >>> "do firmware initialization"
new flow:
PID_1: mwifiex_usb_probe  >>> "do driver initialization" >>> "download the =
firmware"
PID_2: mwifiex_usb_probe  >>> "do interface initialization" >>> "do driver =
initialization"  >>> "do firmware initialization"

>=20
> I guess the question is: is this step supposed to go before, or after fir=
mware
> initilization? Based on that answer, we can make an appropriate patch.

It was before firmware initialization, in the existing driver( and the new =
change also follows this);

>=20
> (The original code does this after FW initialization, and now you're only=
 sort
> of moving it before.)

I don't think so; as per the above flow, things which we moved to init_if()=
 were previously done in mwifiex_usb_dnld_fw(),
just before it return(for PID_2); FW initialization (mwifiex_init_fw()) hap=
pens after that;

Regards,
Ganapathi