Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191004062151.131405-1-kyan@google.com> <20191004062151.131405-2-kyan@google.com>
 <87imp4o6qp.fsf@toke.dk> <CA+iem5vJFRxskyHOKf5K73X8aGH965P4hoiCj-wQtK-Z-47pdg@mail.gmail.com>
 <87pnj9n55y.fsf@toke.dk> <aa40e945adfbeb52890afb2de493142e82ecf69d.camel@sipsolutions.net>
In-Reply-To: <aa40e945adfbeb52890afb2de493142e82ecf69d.camel@sipsolutions.net>
From:   Dave Taht <dave.taht@gmail.com>
Date:   Mon, 7 Oct 2019 12:32:39 -0700
Message-ID: <CAA93jw7xKNG+4HRPOsXKhy0GxX9-EAyu0XSxpyErwbe16wr3pQ@mail.gmail.com>
Subject: Re: [Make-wifi-fast] [PATCH 1/2] mac80211: Implement Airtime-based
 Queue Limit (AQL)
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@redhat.com>,
        Kan Yan <kyan@google.com>,
        Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>,
        Yibo Zhao <yiboz@codeaurora.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Felix Fietkau <nbd@nbd.name>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 7, 2019 at 12:23 PM Johannes Berg <johannes@sipsolutions.net> w=
rote:
>
> On Sun, 2019-10-06 at 19:40 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote=
:
>
> > > That's a good point.  I haven't thought about real simultaneous dual
> > > band chipset and such chipset do exists now. Is RSDB support coming t=
o
> > > mac80211 soon? Just curious if it will be just virtual interfaces or
> > > something else. I chose "local" instead of "sdata" thinking about the
> > > case of several virtual interfaces (AP, STA, MESH) operates in the
> > > same channel, then the interface total could be a better choice.
> > >
> > > I am ok with moving the "aql_total_pending_airtime" into sdata, but
> > > afraid that's not the most optimal choice for the case of multiple
> > > virtual interfaces operates in the same channel.
> > > Maybe we could leave it in "local" for now. What do you think?
> >
> > I'd lean towards keeping it in 'local' for consistency with all the
> > other airtime stuff. For now, I think having multiple SSIDs on the same
> > radio is more common than the reverse (multiple bands on a single
> > radio).
> >
> > In particular, the per-group airtime fairness stuff is definitely
> > designed on the assumption that all BSSes share the same band.
>
> s/band/channel/, presumably.
>
> > So if and when we start supporting true multi-band devices we'll have t=
o
> > change these things anyway. So might as well keep everything together s=
o
> > it all gets fixed :)
>
> I guess I'm OK with that, but I'm pretty sure this will come up sooner
> rather than later ...
>
> What else is there though?

World domination!

>
> johannes
>
> _______________________________________________
> Make-wifi-fast mailing list
> Make-wifi-fast@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/make-wifi-fast


--=20

Dave T=C3=A4ht
CTO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-831-205-9740