Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5360532ybp; Tue, 8 Oct 2019 01:23:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqzyglyA9VclGiQlX+5KBokjHQd86dWsFMIik3BTTk84193lmcYusG3BxCAR/EuqrQ3Vn+dU X-Received: by 2002:a17:906:1347:: with SMTP id x7mr19706671ejb.322.1570523036715; Tue, 08 Oct 2019 01:23:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570523036; cv=none; d=google.com; s=arc-20160816; b=uKB0qqPWDhhhdaEFH+G/ASOmIvs9OMa3qDKwEqQBs3rVTsus1aaba3HgWGAJUXq3Ef 0HM78owdFv/hAxJhzqMfCq8fhAe+gmOpCWoTk/fdsYcsG7RZuXbRAwpY/fvP3jdrV/ac S7MNrV5/nw7OKgfrzysRybRXghotNbVi/2apJdntRHjUYBYNLsuZbtpt2tUJ5IULWGNB rcJFp3m6I+0mRQn7U9LDWYO9utHYYMRwL+fJmHN0sL1Y3u4NTIM0sOC8j3frCU9for2F aBfFCloFYeeVNJ9FMVPZ5SiXJeDKpBHLmiyOcfaZBDUf97MsXumNq6KjESvLY+VM1txK gNvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:authenticated-by; bh=sLxpwDAahPpRAgKgO69Vv/l/mHiOmAWq62Q66Re44QE=; b=un/bW+jbGYNuAsXoBLEcjj2eLpO4IuRyZlY5oq9KuL/O0fMA5T0ahL4O5PGpS08DgD 3ft0SqygDFdz5ZMohVRc+PmStvZjq0O1xG3Qv0kS1wV5diq0DciQ976Ir161QZxFUeeF 22QolCXGX+85BZsQ8Vg2d4jcr53H6UlD7fLRFacwYqg+yjcLkNKDDIwrBort+YOJxRmO iGnSrHPPvud0CzUSqxbQPI9IOBE/iSU3c9d1Nsc8JaHGuxtQI7PRlRt5pm+MxnEnbu63 /h+No0TF4IjkcAnZn9Iqxj2DADrhUzdwzoa8/FzypLWp45q2vIJqdKc/V7nKqD+lXyVv 26dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gh2si8742997ejb.330.2019.10.08.01.23.32; Tue, 08 Oct 2019 01:23:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730617AbfJHIVQ (ORCPT + 99 others); Tue, 8 Oct 2019 04:21:16 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:47349 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728866AbfJHIVP (ORCPT ); Tue, 8 Oct 2019 04:21:15 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID x988L9hR028150, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (RTITCASV01.realtek.com.tw[172.21.6.18]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id x988L9hR028150 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 8 Oct 2019 16:21:09 +0800 Received: from localhost.localdomain (172.21.68.126) by RTITCASV01.realtek.com.tw (172.21.6.18) with Microsoft SMTP Server id 14.3.468.0; Tue, 8 Oct 2019 16:21:09 +0800 From: To: CC: , Subject: [PATCH 07/10] rtw88: Use rtw_write8_set to set SYS_FUNC Date: Tue, 8 Oct 2019 16:20:58 +0800 Message-ID: <20191008082101.2494-8-yhchuang@realtek.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191008082101.2494-1-yhchuang@realtek.com> References: <20191008082101.2494-1-yhchuang@realtek.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.21.68.126] Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Yan-Hsuan Chuang rtw_write8 could modify the values that we do not want to change, use rtw_write8_set instead to only enable the bits of sys_func_en Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c index aa1f15e18c7a..8d72825ed3a7 100644 --- a/drivers/net/wireless/realtek/rtw88/mac.c +++ b/drivers/net/wireless/realtek/rtw88/mac.c @@ -261,7 +261,7 @@ static int rtw_mac_init_system_cfg(struct rtw_dev *rtwdev) value |= BIT_WL_PLATFORM_RST | BIT_DDMA_EN; rtw_write32(rtwdev, REG_CPU_DMEM_CON, value); - rtw_write8(rtwdev, REG_SYS_FUNC_EN + 1, sys_func_en); + rtw_write8_set(rtwdev, REG_SYS_FUNC_EN + 1, sys_func_en); value8 = (rtw_read8(rtwdev, REG_CR_EXT + 3) & 0xF0) | 0x0C; rtw_write8(rtwdev, REG_CR_EXT + 3, value8); -- 2.17.1