Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp5870504ybp; Tue, 8 Oct 2019 09:28:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqya810ej0Dr/JTSK2zmv4U/iMNvTp1GZCAK/f9JKP3vAq37rUMFn8NzrexSElJ4HB+aG6vA X-Received: by 2002:a50:d5c5:: with SMTP id g5mr434219edj.57.1570552097855; Tue, 08 Oct 2019 09:28:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570552097; cv=none; d=google.com; s=arc-20160816; b=BdDHiXX+DNJ7dIYzwJlMNx/BWFbVVWpjJ7C6YNb1tKXZpwpmz4gpTqXZqmE++NYgAk Z93o/LoThhdD8Vb8CynOg74xG2ijk+uR7nwuhbyvI5pLlEXczf+qziP0W7sYm+bbaJSP 7fhYQesylBKTsRV4z88MbCDhCr+J80aoQgVYxJK0rL1Fm1L1Wf5loi2uKqjlC7ljSNlL BkUWZK62BaEyh2p0C1xLI0Zy2k/mhtzqFYsGPAFk3B3eTZ787FZajoSSc07tlmjegFkv t1TYaI2+N2QLV96/mDNO84T1YF7U+ThwR8LfPSX6oyY5I1HlO9cRHG3eXQLx9Wbh/xr6 x8bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from:dkim-signature; bh=nUEi7b2Xg516Vucqorkh6nwu1M0azdgypl+CVmTornQ=; b=asKgh42TtvHVgOibteEQ3LOF2ntSUi/MrxXMN78C2P7nDJKbcCJ7T8LEIQIQPVi6uK mcWB4RXYVRaSKYXzDQLr7YHvrUF8cWVu5C1jg+9kzAtWP7Z1O0N9bVMsb5ELJ+YI3jJK KbrugnY2nZl0907LwMsTU47bQr5CAGoYDxwLpTFib814kKvTXwrCqzNDbYR/PeYdQ0L+ 8p0NE828a9gGTk5rfekeZB2bS6xZIDxPGlFsL7J8sW+ZeUxs7lQdasIWJN0VM592Q/Za Y54yPj2uGfcZV2Zgsqgh8jvurOL72aEmL/HDIzKJDuNW0eRKhK06lSMdJTxTNDDhirsb Zgjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=swu2CpUI; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c20si9225610ejs.197.2019.10.08.09.27.52; Tue, 08 Oct 2019 09:28:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=swu2CpUI; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728804AbfJHQ0T (ORCPT + 99 others); Tue, 8 Oct 2019 12:26:19 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:41291 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbfJHQ0T (ORCPT ); Tue, 8 Oct 2019 12:26:19 -0400 Received: by mail-pf1-f193.google.com with SMTP id q7so11045000pfh.8; Tue, 08 Oct 2019 09:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nUEi7b2Xg516Vucqorkh6nwu1M0azdgypl+CVmTornQ=; b=swu2CpUIg8OQXUWKvhzJvvxfnjce9dVwGW+Kp4Yhmnc1bony+SLXPqGadZxoMQ4X3K ZbwuWTsEGJC+SSZBmHbdlkiEgJ6xLEoBool16ohacH09/pmV5epWPyyKXnGdpgJsJsd9 IH6K0bjoidSfQwjaQRtw1bEqSbsTqM9lfgFLYQKo8F2p2UogSrIS7Wy0+oWSt9EFwbFG c5EgQ4SPBSHMMPpjRLT9thMWIthzCrKjCzqXqp40AYQZ846Lzj6LQincDbw44UjK7SFS pc2KNdtk49cYUzCT6YF4+ikr61GIINh3zd9cL3YIsLqFxXRVCoV8L3kEk/tq8ZmlaG0b VF3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nUEi7b2Xg516Vucqorkh6nwu1M0azdgypl+CVmTornQ=; b=tt1SShwh/uVHrRcHtUlZ93LlobBNnPgur/Va5ADgMew2TbuCWBf9EXgK4F7aGxI3gu DkVMnmhXFHge4c4hsxXjOmf1ACKBi6Ne4YXtEP2wgjtJLOxZiIVYvKN6vdcsEwUXSYbB aeo7SzWcV+bWjuYGGUr7YCu7w0QS85K2pfK55DcmV8k5+qHzpQ1cH0cPDkixJMO05KKh Pfdnm5HIdaVRWZ9gkt4Oy6sqKgE3q81SWrn4YWRJIuolCvJSV0IBXy1PIJBLMCd20pcR fnsXGNg9gD+rMLSjxRTueIcZAOPvvhIA7P0paTfqYbRdtKX2phIfRIAt5MVtUNHLSbxH oR4A== X-Gm-Message-State: APjAAAW88g/ghdgO4z8nAhw78gNC9TLzIcJcBm4yutvDCcW7Y6x+xQgD LFf97HwfEogrD4FIbfdzxU9IMC3Z X-Received: by 2002:a62:2f84:: with SMTP id v126mr40203018pfv.167.1570551977393; Tue, 08 Oct 2019 09:26:17 -0700 (PDT) Received: from ?IPv6:2620:10d:c082:1055::2a69? ([2620:10d:c090:200::3:df92]) by smtp.gmail.com with ESMTPSA id b5sm15704840pgb.68.2019.10.08.09.26.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2019 09:26:16 -0700 (PDT) From: Jes Sorensen X-Google-Original-From: Jes Sorensen Subject: Re: [PATCH] rtl8xxxu: make arrays static, makes object smaller To: Colin King , Kalle Valo , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191007135313.8443-1-colin.king@canonical.com> Message-ID: <87e99b3b-6b1d-4eeb-f08f-00cfff5e3b2b@gmail.com> Date: Tue, 8 Oct 2019 12:26:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191007135313.8443-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 10/7/19 9:53 AM, Colin King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack but instead make them > static. Makes the object code smaller by 60 bytes. > > Before: > text data bss dec hex filename > 15133 8768 0 23901 5d5d realtek/rtl8xxxu/rtl8xxxu_8192e.o > 15209 6392 0 21601 5461 realtek/rtl8xxxu/rtl8xxxu_8723b.o > 103254 31202 576 135032 20f78 realtek/rtl8xxxu/rtl8xxxu_core.o > > After: > text data bss dec hex filename > 14861 9024 0 23885 5d4d realtek/rtl8xxxu/rtl8xxxu_8192e.o > 14953 6616 0 21569 5441 realtek/rtl8xxxu/rtl8xxxu_8723b.o > 102986 31458 576 135020 20f6c realtek/rtl8xxxu/rtl8xxxu_core.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King Looks fine to me! Assume you mean x86_64 since there's no such thing as an amd64 architecture :) Cheers, Jes