Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature
To:     Johannes Berg <johannes@sipsolutions.net>,
        James Prestwood <prestwoj@gmail.com>,
        linux-wireless@vger.kernel.org
References: <20190913195908.7871-1-prestwoj@gmail.com>
 <20190913195908.7871-2-prestwoj@gmail.com>
 <c6835b5c5d2a97fa82b0fb21f7b7f0056aa42e1b.camel@sipsolutions.net>
 <90ae00044bc0834d87d3f9fb75ce63dce4cfadd5.camel@gmail.com>
 <0b57c1288016310050ccd6233dda886fc4a89b02.camel@gmail.com>
 <f468a8d573ddf401d2084b76eb625fef5950f265.camel@sipsolutions.net>
 <6fa34e4c-5c81-4875-da29-cada1a078e2c@gmail.com>
 <6530a6b06176790c5a6949d6ffccf37b506975bd.camel@sipsolutions.net>
 <864267ec-9158-940d-6e0e-db84a395888e@gmail.com>
 <f02b81f6dac29da911f8793b952a9efb6a1fdb62.camel@sipsolutions.net>
 <1bb5450b-bc4e-8c83-f99e-fc7e739b08f0@gmail.com>
 <fbb287a82656dd3f89817590e86b23d6968a2822.camel@sipsolutions.net>
 <193168d4-6466-60a4-bc89-c4a44e84ac46@gmail.com>
 <9c49ec27489333d7f27831de19e9d1c9cd65eeee.camel@sipsolutions.net>
From:   Denis Kenzior <denkenz@gmail.com>
Message-ID: <cc2cee76-2a83-17ad-0e7a-ba71075e1497@gmail.com>
Date:   Tue, 8 Oct 2019 15:55:56 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <9c49ec27489333d7f27831de19e9d1c9cd65eeee.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Johannes,

On 10/8/19 3:16 PM, Johannes Berg wrote:
> On Tue, 2019-10-08 at 13:50 -0500, Denis Kenzior wrote:
>> Hi Johannes,
>>
>>>> But they shouldn't change due a mac address change?  I wonder if we can
>>>> further relax the requirements to allow mac change if
>>>> NL80211_SCAN_FLAG_RANDOM_ADDR was used?
>>>
>>> No, at least with HW scan that would completely confuse the driver -
>>> since from the driver's POV we'd remove the interface it's currently
>>> managing the scan for.
>>
>> So help me understand this better.
> 
> include/net/mac80211.h:
> 
>         int (*hw_scan)(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
>                        struct ieee80211_scan_request *req);
> 
> How is it difficult to understand that with an API like that, it might
> not be a good idea to remove the vif from the driver while it's
> scanning?

Right, so you're talking in the context of this implementation which 
performs a remove/add interface.  You're right about that.

But I was asking more in general terms.  If all we're doing is scanning, 
can we just change the mac?  Anyway, not important.  Maybe I bring this 
up once this set is accepted.

Regards,
-Denis