Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp903014ybp; Wed, 9 Oct 2019 06:05:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMGvqa4sA35Dr4J7l0o/Nfj/cNzJrIng4/7UAUVThsGfh62vmnvVr+ljVL1JESOCIy3wBG X-Received: by 2002:a17:906:688:: with SMTP id u8mr2795444ejb.208.1570626358682; Wed, 09 Oct 2019 06:05:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570626358; cv=none; d=google.com; s=arc-20160816; b=p58i8Db17QnDScfMaS00HT6EyNtzbpxjAsgSU/OGR7R+9rzmJ0ORzZdHpFeEVyjqe9 KxnTy1g7hZLSu6ucEY+u7Iha4loEJbcW7B+W+VSmaXOfm4UZYE22zldur57Ikt850kZ1 +L3BqDvqh2XJ+ATmaZ61Yy0Cs+MN2f+tv7OWb796HE+fGNP/IYsk1QBzDbwr3KoE9Om/ SMoY1vtlSpZNbECNJ0PeRUpLyE+A9wFN9cyyq53nRmkE8Fw2t8lLHbMjuthO8AZiaweN wT+HDYmYsO5Tie3hnkaC8xrHoe4kRflfmuxq1YMG1Towd6ewmddNkNLXuYWYWHuswWYK wvqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=fdXMCm3wCCMgj2/CDuqUOrruAbxu8lfqiqS7NwAsiG8=; b=radeo8ynYF18DyTtsH3okIM22bmXDdV0J0YrUO18+ySobCgDYmSnX7za5ukJBxWmLq efeir1RWwS8H/qWQy73uwL1j1Sn6qwr7xfvkg3bKN9S8RfjNcdHcNnSxIeMRzcdsBPGP LnyQVyoHCQgmyfzbRDYeDiQhwl3K9WA80SrBtH96Sx0gYBf28R0e2yUO9UyNElY74jcH Jb+xmBe3SiL5HJresIcYE/baTr5Wx1XFj6lbSgwoFJVNrscSEpfkuthyeRvmhCL3ow/A xcrsRc0UH1a7988xfDKwzWEOZ/RGjk96FqgELleskEPFFwBvxLzaUCsd3oSYjGj8g92G oYqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DpAT1j6g; dkim=pass header.i=@codeaurora.org header.s=default header.b=DpAT1j6g; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ng7si1097294ejb.91.2019.10.09.06.05.33; Wed, 09 Oct 2019 06:05:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DpAT1j6g; dkim=pass header.i=@codeaurora.org header.s=default header.b=DpAT1j6g; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731213AbfJINFU (ORCPT + 99 others); Wed, 9 Oct 2019 09:05:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59582 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730858AbfJINFU (ORCPT ); Wed, 9 Oct 2019 09:05:20 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7FC4860A0A; Wed, 9 Oct 2019 13:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570626319; bh=bjOfTcUli05MCxYRKbenEga8hmz//QUQKdpP/IaUV+c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DpAT1j6gClBIihophJBzw1a7tHsaek11AZUCDBiEboBeX8Rhv4igF4+NqLzt6j51w VZVn7GopBY1O3V6FvCQ39ZXhrY817REUNwdq/nGw4pk44jvm8UM5+SBiwDFFiSbvNi IiyAO0IakIzp9bEa3NsM28BC1K0SxiK1QDFN1pU4= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from x230.qca.qualcomm.com (85-76-42-199-nat.elisa-mobile.fi [85.76.42.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9727F602E1; Wed, 9 Oct 2019 13:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570626319; bh=bjOfTcUli05MCxYRKbenEga8hmz//QUQKdpP/IaUV+c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DpAT1j6gClBIihophJBzw1a7tHsaek11AZUCDBiEboBeX8Rhv4igF4+NqLzt6j51w VZVn7GopBY1O3V6FvCQ39ZXhrY817REUNwdq/nGw4pk44jvm8UM5+SBiwDFFiSbvNi IiyAO0IakIzp9bEa3NsM28BC1K0SxiK1QDFN1pU4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9727F602E1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: "zhengbin \(A\)" Cc: , , Subject: Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err' References: <1570612107-13286-1-git-send-email-zhengbin13@huawei.com> <8736g2rs86.fsf@codeaurora.org> <0135c3c7-a827-941a-1bad-90129c49d0ac@huawei.com> Date: Wed, 09 Oct 2019 16:05:15 +0300 In-Reply-To: <0135c3c7-a827-941a-1bad-90129c49d0ac@huawei.com> (zhengbin's message of "Wed, 9 Oct 2019 21:01:54 +0800") Message-ID: <87y2xuqdbo.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "zhengbin (A)" writes: > On 2019/10/9 20:58, Kalle Valo wrote: >> zhengbin writes: >> >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw: >>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: >>> variable err set but not used [-Wunused-but-set-variable] >>> >>> Reported-by: Hulk Robot >>> Signed-off-by: zhengbin >>> Acked-by: Ping-Ke Shih >> There's no changelog, why did you resend? Document clearly the changes >> so that maintainers don't need to guess what has changed: > > Failed to apply: > > fatal: corrupt patch at line 13 > error: could not build fake ancestor > Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err' > Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err' > The copy of the patch that failed is found in: .git/rebase-apply/patch > > So I resend this. Ok, thanks. But next time include the changelog automatically and mark the patch as v2. And read the documentation: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- Kalle Valo