Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used
 variable 'err'
To:     Kalle Valo <kvalo@codeaurora.org>
CC:     <pkshih@realtek.com>, <linux-wireless@vger.kernel.org>,
        <netdev@vger.kernel.org>
References: <1570612107-13286-1-git-send-email-zhengbin13@huawei.com>
 <8736g2rs86.fsf@codeaurora.org>
 <0135c3c7-a827-941a-1bad-90129c49d0ac@huawei.com>
 <87y2xuqdbo.fsf@codeaurora.org>
From:   "zhengbin (A)" <zhengbin13@huawei.com>
Message-ID: <e9c16275-16bc-25d0-9761-abcb0e47b2f4@huawei.com>
Date:   Wed, 9 Oct 2019 21:06:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <87y2xuqdbo.fsf@codeaurora.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 2019/10/9 21:05, Kalle Valo wrote:
> "zhengbin (A)" <zhengbin13@huawei.com> writes:
>
>> On 2019/10/9 20:58, Kalle Valo wrote:
>>> zhengbin <zhengbin13@huawei.com> writes:
>>>
>>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>>
>>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
>>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning:
>>>> variable err set but not used [-Wunused-but-set-variable]
>>>>
>>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
>>>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>>> There's no changelog, why did you resend? Document clearly the changes
>>> so that maintainers don't need to guess what has changed:
>> Failed to apply:
>>
>> fatal: corrupt patch at line 13
>> error: could not build fake ancestor
>> Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err'
>> Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err'
>> The copy of the patch that failed is found in: .git/rebase-apply/patch
>>
>> So I resend this. 
> Ok, thanks. But next time include the changelog automatically and mark
> the patch as v2. And read the documentation:
Copy that, thank your for your patience
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>