Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 901CE60159
From:   Kalle Valo <kvalo@codeaurora.org>
To:     <yhchuang@realtek.com>
Cc:     <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>
Subject: Re: [PATCH 02/10] rtw88: Enable 802.11ac beamformee support
References: <20191008082101.2494-1-yhchuang@realtek.com>
        <20191008082101.2494-3-yhchuang@realtek.com>
Date:   Mon, 14 Oct 2019 12:38:36 +0300
In-Reply-To: <20191008082101.2494-3-yhchuang@realtek.com> (yhchuang's message
        of "Tue, 8 Oct 2019 16:20:53 +0800")
Message-ID: <87v9srfyzn.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

<yhchuang@realtek.com> writes:

> From: Tzu-En Huang <tehuang@realtek.com>
>
> Enable MU-MIMO transmit beamformee support for chipset 8822b and 8822c.
>
> If the rtw88 is in station mode and associated with an AP, and the
> capabilities of both meet the requirement of beamforming, driver will
> run as a beamformee and the corresponding chip settings will be set.
>
> In addition, module parameter support_bf is added to enable or disable
> beamforming.

Why do you need a module parameter? Module paramaters are not meant to
be replacement for ini files, where you have a setting to enable or
disable each future. Module parameters should be added only for really
good reasons.

> +void rtw_bf_assoc(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
> +		  struct ieee80211_bss_conf *bss_conf)
> +{
> +	struct ieee80211_hw *hw = rtwdev->hw;
> +	struct rtw_vif *rtwvif = (struct rtw_vif *)vif->drv_priv;
> +	struct rtw_bfee *bfee = &rtwvif->bfee;
> +	struct rtw_bf_info *bfinfo = &rtwdev->bf_info;
> +	struct rtw_chip_info *chip = rtwdev->chip;
> +	struct ieee80211_sta *sta;
> +	struct ieee80211_sta_vht_cap vht_cap;
> +	struct ieee80211_sta_vht_cap ic_vht_cap;
> +	u32 sound_dim;
> +	u8 *bssid, i;
> +
> +	if (chip->band & RTW_BAND_5G) {
> +		ic_vht_cap = hw->wiphy->bands[NL80211_BAND_5GHZ]->vht_cap;
> +		if (!(ic_vht_cap.cap &
> +		      (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE |
> +		       IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)))
> +			goto exit;
> +	} else {
> +		goto exit;
> +	}
> +
> +	bssid = (u8 *)bss_conf->bssid;

This cast looks very fishy, you are again casting away const. Like I
said in patch 1, avoid casts as much as possible. They are fragile and
can easily create bugs if you are not careful.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches