Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5C9C0602E0
From:   Kalle Valo <kvalo@codeaurora.org>
To:     <yhchuang@realtek.com>
Cc:     <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>
Subject: Re: [PATCH 05/10] rtw88: update regulatory settings implementaion
References: <20191008082101.2494-1-yhchuang@realtek.com>
        <20191008082101.2494-6-yhchuang@realtek.com>
Date:   Mon, 14 Oct 2019 12:39:37 +0300
In-Reply-To: <20191008082101.2494-6-yhchuang@realtek.com> (yhchuang's message
        of "Tue, 8 Oct 2019 16:20:56 +0800")
Message-ID: <87r23ffyxy.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

<yhchuang@realtek.com> writes:

> From: Tzu-En Huang <tehuang@realtek.com>
>
> There are two kinds of country/regulatory efuse settings
> for Realtek's chipset, one is worldwide and the other is
> a specific country. For the chipset with the country setting
> being a specific country, driver needs to ensure that the
> setting will not be modified when connecting to an AP.
>
> For the chipset with the country setting is worldwide,
> driver will follow the NL80211_REGDOM_SET_BY_COUNTRY_IE
> regulatory notification from the mac80211 stack.
>
> Signed-off-by: Tzu-En Huang <tehuang@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> ---
>  drivers/net/wireless/realtek/rtw88/main.c |  9 +++-
>  drivers/net/wireless/realtek/rtw88/main.h |  2 +
>  drivers/net/wireless/realtek/rtw88/regd.c | 61 +++++++++++++++++++----
>  3 files changed, 59 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
> index 570b2e358be4..edd490c507b5 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -21,14 +21,17 @@ EXPORT_SYMBOL(rtw_fw_lps_deep_mode);
>  bool rtw_bf_support = true;
>  unsigned int rtw_debug_mask;
>  EXPORT_SYMBOL(rtw_debug_mask);
> +bool rtw_allow_user_reg_set;
>  
>  module_param_named(lps_deep_mode, rtw_fw_lps_deep_mode, uint, 0644);
>  module_param_named(support_bf, rtw_bf_support, bool, 0644);
>  module_param_named(debug_mask, rtw_debug_mask, uint, 0644);
> +module_param_named(allow_user_reg_set, rtw_allow_user_reg_set, bool, 0644);
>  
>  MODULE_PARM_DESC(lps_deep_mode, "Deeper PS mode. If 0, deep PS is disabled");
>  MODULE_PARM_DESC(support_bf, "Set Y to enable beamformee support");
>  MODULE_PARM_DESC(debug_mask, "Debugging mask");
> +MODULE_PARM_DESC(allow_user_reg_set, "Set Y to allow regulatory settings from user");

Why the module parameter?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches