Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authenticated-By: 
From:   Tony Chuang <yhchuang@realtek.com>
To:     "g.schlmm" <g.schlmm@googlemail.com>,
        "briannorris@chromium.org" <briannorris@chromium.org>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: rtw88: M.2 RTL8822BE not working - rfe 3 isn't supported
Thread-Topic: rtw88: M.2 RTL8822BE not working - rfe 3 isn't supported
Thread-Index: AQHVHfV5qrKScUVcP06geVYCQL9tp6aXPCwAgAOaooCAv3qhAIABgmyg
Date:   Tue, 15 Oct 2019 03:27:07 +0000
Message-ID: <F7CD281DE3E379468C6D07993EA72F84D18FDB51@RTITMBSVM04.realtek.com.tw>
References: <0d0159a8-a83e-cef3-fd32-4928a2301719@gmail.com>
 <20190612091330.GC2965@redhat.com>
 <F7CD281DE3E379468C6D07993EA72F84D180639E@RTITMBSVM04.realtek.com.tw>
 <5960cc5a-becf-8bdc-7898-b9933247b6e3@gmail.com>
In-Reply-To: <5960cc5a-becf-8bdc-7898-b9933247b6e3@gmail.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> From: g.schlmm 
> 
> On 14.06.19 10:24, Tony Chuang wrote:
> >> Subject: Re: rtw88: M.2 RTL8822BE not working - rfe 3 isn't supported
> >>
> >> Cc Tony
> >>
> >> On Sat, Jun 08, 2019 at 02:26:51PM +0200, g.schlmm wrote:
> >>> my RTL8822BE M.2 card is not working with linux 5.2rc3
> >>>
> >>> the staging r8822be driver in linux 5.1 was working for this card
> >>>
> >>> from dmesg:
> >>>> [    8.001186] rtw_pci 0000:04:00.0: rfe 3 isn't supported
> >>>> [    8.003870] rtw_pci 0000:04:00.0: failed to setup chip efuse info
> >>>> [    8.006405] rtw_pci 0000:04:00.0: failed to setup chip information
> >>>
> >>> lspci:
> >>>> 04:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd.
> >> RTL8822BE 802.11a/b/g/n/ac WiFi adapter
> >>>>         Subsystem: Lenovo RTL8822BE 802.11a/b/g/n/ac WiFi
> adapter
> >>>>         Flags: fast devsel, IRQ 19
> >>>>         I/O ports at c000 [size=256]
> >>>>         Memory at 81200000 (64-bit, non-prefetchable) [size=64K]
> >>>>         Capabilities: [40] Power Management version 3
> >>>>         Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+
> >>>>         Capabilities: [70] Express Endpoint, MSI 00
> >>>>         Capabilities: [100] Advanced Error Reporting
> >>>>         Capabilities: [148] Device Serial Number
> >> 00-e0-4c-ff-fe-b8-22-01
> >>>>         Capabilities: [158] Latency Tolerance Reporting
> >>>>         Capabilities: [160] L1 PM Substates
> >>>>         Kernel modules: rtwpci
> >>
> >
> > Hi,
> >
> > Please use the attached patch. And RFE type 3 has not been well tested,
> > I am not sure if the quality is expected. But it should work fine I guess.
> > If there is any further problems, just tell me, thanks.
> >
> > Yan-Hsuan
> >
> 
> Hi,
> 
> the above patch doesnt apply anymore on newer kernel sources.
> can we except to see rfe type 3 support in the mainline kernel?
> what can i do to help testing, if testing is still needed?
> 

That's fine, I'll fix the conflicts and send them to mainline.
Also I will try to fix the array usage of the tables, use struct instead.
That was requested by Brian before.

Yan-Hsuan