Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2865449ybg; Sun, 20 Oct 2019 02:00:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwpl+/BDuEwURLqaITI/gJ+2Pk5WbDqOIYSNgjFHle073YWEur2sxsjnEphOva7VpyVS7g9 X-Received: by 2002:aa7:c248:: with SMTP id y8mr5638187edo.74.1571562016235; Sun, 20 Oct 2019 02:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571562016; cv=none; d=google.com; s=arc-20160816; b=HIxp/oA0zuIuM1DXHTLcEdoNyBfbPe7SU+jhFxNd8lERCo8fTJyvixjFqt4jE74Wba 6Rv0QmVued+oP0Qm3x5iZ4BEOd0PG6TP4cD42o6hHwFryDWnp6mU7LvcnTdsIOzU5ukv CCso6UVtvNrcbhQ4LwNAD7Q+nWLpr+OayI//Wbz1M9OOH35zAQnY1lyMCdEvlddSDqrh 8OH26OSwLaJVhVUQSc6lRKOm6ExDs38vOycsWhJdrDJpMZedJVie5Jh4/x3fGR5I/fIe GddF+2ILglFgAyECpllKwPxq1BAr6Y6dA80yzSsIXIDD6JTb1sT10Onk7nbP/oAlhtLY U3rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:cc:to:from; bh=++jWKHDm9aUG2MndKFpogRur1csVTNJX29i077ZPO88=; b=EAr/PBXgqb7CDaptv1+Fab5YfcHXJXug49UsZL2j0YHEXf2yqmhlfkbk7qnoy8s15c z5P4UB60NZoO+yYmgnYh4iC4afiWsVRnh85kYYgHyKCVfWqansQFRtCqCNV9MbNOaT0s DmA9nrvMJMVTXihukVxhTbgi57q/VOtMqF/ujauU5s1lq+6Gr2YAyXBaErKM0T5wEf89 FNDZE4wSkisYFUjODzXNQlBWenQVw1i5b1pxqaY+JYWSRCmGUX6zNtoghtRH+ugC5X9w KjC0VrS6u5UwCTrHCDTyjGoXH13IGIqdUSb0vYKTA5f4oR6Erz5WgcBJHSe4hFm/6h/c ZWOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2si7624468edq.264.2019.10.20.01.59.51; Sun, 20 Oct 2019 02:00:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726326AbfJTI4K (ORCPT + 99 others); Sun, 20 Oct 2019 04:56:10 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:50838 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726115AbfJTI4K (ORCPT ); Sun, 20 Oct 2019 04:56:10 -0400 Received: from [91.156.6.193] (helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92) (envelope-from ) id 1iM70M-0003LY-SR; Sun, 20 Oct 2019 11:56:03 +0300 From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Sun, 20 Oct 2019 11:55:45 +0300 Message-Id: <20191020085545.16407-11-luca@coelho.fi> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191020085545.16407-1-luca@coelho.fi> References: <20191020085545.16407-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: [PATCH 12/12] iwlwifi: mvm: fix non-ACPI function Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg The code now compiles without ACPI, but there's a warning since iwl_mvm_get_ppag_table() isn't used, and iwl_mvm_ppag_init() must not unconditionally fail but return success instead. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index e842133779f4..18b62727b6d7 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -889,11 +889,6 @@ static int iwl_mvm_sar_geo_init(struct iwl_mvm *mvm) return 0; } -static int iwl_mvm_get_ppag_table(struct iwl_mvm *mvm) -{ - return -ENOENT; -} - int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm) { return -ENOENT; @@ -901,7 +896,7 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm) static int iwl_mvm_ppag_init(struct iwl_mvm *mvm) { - return -ENOENT; + return 0; } #endif /* CONFIG_ACPI */ -- 2.23.0