Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2796060112
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     linux-wireless@vger.kernel.org, pkshih@realtek.com,
        Stable <stable@vger.kernel.org>
Subject: Re: [PATCH V3] rtlwifi: rtl_pci: Fix problem of too small skb->len
References: <20191021005658.31391-1-Larry.Finger@lwfinger.net>
Date:   Mon, 21 Oct 2019 16:53:40 +0300
In-Reply-To: <20191021005658.31391-1-Larry.Finger@lwfinger.net> (Larry
        Finger's message of "Sun, 20 Oct 2019 19:56:58 -0500")
Message-ID: <87zhhuurvf.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Larry Finger <Larry.Finger@lwfinger.net> writes:

> In commit 8020919a9b99 ("mac80211: Properly handle SKB with radiotap
> only"), buffers whose length is too short cause a WARN_ON(1) to be
> executed. This change exposed a fault in rtlwifi drivers, which is fixed
> by regarding packets with skb->len <= FCS_LEN as though they are in error
> and dropping them. The test is now annotated as likely.
>
> Cc: Stable <stable@vger.kernel.org> # v5.0+
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> V2 - content dropped
> V3 - changed fix to drop packet rather than arbitrarily increasing the length.

Much better, thanks.

> Material for 5.4.

Ok, I'll queue it for v5.4.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches