Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191022100420.25116-1-yhchuang@realtek.com> <20191022100420.25116-3-yhchuang@realtek.com>
 <CAB4CAwes6r17gCGF-WKB=i9cN8dz6evA_g9SGzNdmJXsNcmTxQ@mail.gmail.com> <F7CD281DE3E379468C6D07993EA72F84D19069EB@RTITMBSVM04.realtek.com.tw>
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D19069EB@RTITMBSVM04.realtek.com.tw>
From:   Chris Chiu <chiu@endlessm.com>
Date:   Wed, 23 Oct 2019 11:00:46 +0800
Message-ID: <CAB4CAwekWUcJUSPYaRrmqp78ctUhfoGzLyrwoVjxMTMSOHGcSg@mail.gmail.com>
Subject: Re: [PATCH v3 2/5] rtw88: add power tracking support
To:     Tony Chuang <yhchuang@realtek.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Brian Norris <briannorris@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 23, 2019 at 10:23 AM Tony Chuang <yhchuang@realtek.com> wrote:
>
> >
> > I don't see any chance that delta_power_index[] will be < 0. Either from
> > rtw_phy_pwrtrack_get_pwridx() or swing_table.
> >
> > Maybe just use u8 instead of s8?
> >
>
> I think "return -delta_swing_table_idx_neg[delta];" should be stored
> with s8 ?
>

Sorry for missing that. I was somehow misled by the naming 'power_index'.

> Yan-Hsuan