Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp631967ybg; Wed, 23 Oct 2019 03:32:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzvZd4hE1uG3uhwzyRpkdErR2GHiwCamA4LJwAO7qdCAIi6+7NqP93U6UKf0GUSds3ciVHG X-Received: by 2002:a17:906:6d87:: with SMTP id h7mr32508373ejt.4.1571826767907; Wed, 23 Oct 2019 03:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571826767; cv=none; d=google.com; s=arc-20160816; b=Cw3U8JO3MJw8zpJzb7x9uJuMY618l7U/1VJrq/rQ4rcOYszc0jPVr04o8V/Zq2BHG5 hc+eb0RVHMv+eUQEsnxaDVklgpvOojwpJiqMEZVgZE9g0pKYGrITGvtEc9OsWMv0omYX rk6H3ADD9/hNsKcnnlEF7w0lHLQPne06xb49P7RtWQrzxc/Iv1jcSw3u2CWxnEQBpVnO TQIvO6xW4keoOB14O+6zKUzQk/Y63UcfqP0M8Qj6hFPQBmqcF2dMmimLz+0otIpqK/Ey wb0EzX6RWPq8RYIrK4F6B8tBIBhlHf3WcfFeKiFiV9GWi5dGqJ9lTaiJ8qIpSkt9yWx7 uETA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=IT4Pj1K8aoLNEl9q+NpCer/7p6YXgiRSct64udqdBKQ=; b=NpCL2gBDfHgdjiCc9qruG4DfxtawBoNrpAGBSDRWRwa786RKNlr+ULpSSh1sIU8Y7q +K38yirVE7oPXShp+7Qj+cmuOhE0A4CSxwFuEjtSYhhr0iTZr0Jz0s8XQaYPJsjJUijD O0o95nYdOuWckMRmPZ7XoaJXRbp/gd5CQnUDmW/Wc/Vk5QvCKqKCEjpkmFpQGxAJvVcH DLah7cYyn80whDsNBkaw8KZaMfTyubyqjAgOcstD4zjtkefvAea51VXsYsOb3yNPpAOo PcdJ1wxRkZQqLbBjV91dfND4c/69gQ02LgdEBuuzQPkB7No4VD8H/EUszLtL/Mu42cPV PRUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=b+PMNTWd; dkim=pass header.i=@codeaurora.org header.s=default header.b=BdJTj+l9; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jo12si1668067ejb.176.2019.10.23.03.32.23; Wed, 23 Oct 2019 03:32:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=b+PMNTWd; dkim=pass header.i=@codeaurora.org header.s=default header.b=BdJTj+l9; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404485AbfJWKbM (ORCPT + 99 others); Wed, 23 Oct 2019 06:31:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36998 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404361AbfJWKbM (ORCPT ); Wed, 23 Oct 2019 06:31:12 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0BFBD60930; Wed, 23 Oct 2019 10:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571826671; bh=A7PH/myWbf3inKtiwdNO1H56o0VQY99LFEVNO9VJcYI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=b+PMNTWdS5DOqqkGKvYp2t6oxZ/dXXyLkHo+IRWyH6WilDLax4HfBK98xeHRMFgtg cYk6tvk/ySvQaVsGZytvVz0+gqXcb3k8cbQjTSZ4sncD+2/4EvfpBZHgsZeDW838JR /vz1oSxkWXLwxAR4eNoBv5hyMlGCfmmTu4hNA9kE= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (unknown [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7EFF460159; Wed, 23 Oct 2019 10:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571826670; bh=A7PH/myWbf3inKtiwdNO1H56o0VQY99LFEVNO9VJcYI=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=BdJTj+l9l+3+2vg6/W+RoAoS/4bkEnbl6+SPdTIPVduhbF/kVckJ5z3dpvZufKzZ/ hjA9FNNQu2BA/aDtUDILqOJlfjrjyf2rjh8lYdvkeQhRcl8DwuHO0blNuT1I6CTF3M ygIHGL8X0YhJ6oUgfiPr5StwpPtoOJv/VA+DLaPE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7EFF460159 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] rtlwifi: Fix potential overflow on P2P code From: Kalle Valo In-Reply-To: <20191018114321.13131-1-labbott@redhat.com> References: <20191018114321.13131-1-labbott@redhat.com> To: Laura Abbott Cc: Ping-Ke Shih , Laura Abbott , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Waisman User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191023103111.0BFBD60930@smtp.codeaurora.org> Date: Wed, 23 Oct 2019 10:31:11 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Laura Abbott wrote: > Nicolas Waisman noticed that even though noa_len is checked for > a compatible length it's still possible to overrun the buffers > of p2pinfo since there's no check on the upper bound of noa_num. > Bound noa_num against P2P_MAX_NOA_NUM. > > Reported-by: Nicolas Waisman > Signed-off-by: Laura Abbott > Acked-by: Ping-Ke Shih Patch applied to wireless-drivers.git, thanks. 8c55dedb795b rtlwifi: Fix potential overflow on P2P code -- https://patchwork.kernel.org/patch/11198315/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches