Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp633422ybg; Wed, 23 Oct 2019 03:34:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRT1RTzZmfVpgzwXDs/tBpEUBfFgrzchbXMzivySjrXAKfw1j5wJytWLs38T8BZNnG4ILI X-Received: by 2002:a17:906:5004:: with SMTP id s4mr6885897ejj.26.1571826855315; Wed, 23 Oct 2019 03:34:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571826855; cv=none; d=google.com; s=arc-20160816; b=XCtrvGvglDCnah8Z9K9/NKT6FKbMM7do3EObt5TxpGXRcqotYmz/4ZYqjtD3BwIlPb amcPlSTdFKTozUs+kBVctVzWkIto/dLbRCc4bTolCFJyORD69SDLWPyTD2I+9Ptkf5Za hM8uWvqVt+X6WyBonDjPxgKIurksGVfGiPFaS7yzcW0d8L1M0Yaqeuukj+TJPBi3hE+d FolxsZLcumJOTWsZkhw8QPXqFZOS/XmCPutT9Opxu9nrtJlOcTDelRUDa6RJg+SoLVKj 5PLOKrUD58uoMsrgrH4roLJLuIOlbLvRX6KOGwTdcj2H8xp4HU3T8nfh+RDvuEJP3ZBg USjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=UoUlfF7ZphjgPZCQmAwWjy5D+35/RoW8B0ntn0ZAxgc=; b=gu2devI1/hdh+gi7dTeFwFZ6PCD6z2AjA0qKuf5lCvhLKM240gqa1MXPAUWMdl2nQO +CtgD7nKopIfsW0zZUgiimt8WfQ8LM8EG+1846N83BZNtfW3NqsTwi7n/UIkAk655BLG iKuKiiAWBg7ExW0K9ZRwvpiSnRASpQhu1ZGbzbcrCyoA1v92aupgcB8ekY2aTqNrVvz9 g39bN4A3yOS6LKs0NuZwOV2xviwrZStb9qf82rZkEJukI0AKvU6rFmijn7iaijs1InkZ L4c+PXS0f5dKZlFWsS3wu75+K/f5QAcXZag2HzDnAnjS1m//H8yUh3NE4Y/BWvzHCWSF 0xFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DeMLwall; dkim=pass header.i=@codeaurora.org header.s=default header.b=goafbxiG; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g25si12932873edr.71.2019.10.23.03.33.51; Wed, 23 Oct 2019 03:34:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DeMLwall; dkim=pass header.i=@codeaurora.org header.s=default header.b=goafbxiG; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404527AbfJWKdC (ORCPT + 99 others); Wed, 23 Oct 2019 06:33:02 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39230 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404332AbfJWKdC (ORCPT ); Wed, 23 Oct 2019 06:33:02 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B84DA60D86; Wed, 23 Oct 2019 10:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571826781; bh=l84I2WzziNV0BD7aWEgYq1Gv5TQrtmbb7A4bQSUnGMI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=DeMLwallnvKpf6EdDyfn5vw4Aer15gWMLZbEkaQkbyYohV/pWawrPiturV/uUAt8F le4fTpsi8ovBhGQlkl3fPZs2Z5fbiMW3EUDl4JZxe2yT4vH7YRgwUzTnsdzF0+rTxF ZpiCOfxa+gBWPfCxljL30PMMUYfymx6Te4htLSR0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (unknown [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7A0F4601EA; Wed, 23 Oct 2019 10:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571826779; bh=l84I2WzziNV0BD7aWEgYq1Gv5TQrtmbb7A4bQSUnGMI=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=goafbxiGZYl6WAiJzjIzGM7OsIf48Zg+jzoDnLGTqWh5+0yqWLWfIiJHlFiocw1YX W8Xjf2s6IIJrdmULC0y9BNrNFG2oF+uQihDdoffAnbbZzNtj8HC0qzzZmULsEWLUvB eQTdhB6DFk8wXTDg/IW/Ct9sUJR+uktB/xaBvIEs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7A0F4601EA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH V3] rtlwifi: rtl_pci: Fix problem of too small skb->len From: Kalle Valo In-Reply-To: <20191021005658.31391-1-Larry.Finger@lwfinger.net> References: <20191021005658.31391-1-Larry.Finger@lwfinger.net> To: Larry Finger Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com, Larry Finger , Stable User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191023103300.B84DA60D86@smtp.codeaurora.org> Date: Wed, 23 Oct 2019 10:33:00 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Larry Finger wrote: > In commit 8020919a9b99 ("mac80211: Properly handle SKB with radiotap > only"), buffers whose length is too short cause a WARN_ON(1) to be > executed. This change exposed a fault in rtlwifi drivers, which is fixed > by regarding packets with skb->len <= FCS_LEN as though they are in error > and dropping them. The test is now annotated as likely. > > Cc: Stable # v5.0+ > Signed-off-by: Larry Finger Patch applied to wireless-drivers.git, thanks. b43f4a169f22 rtlwifi: rtl_pci: Fix problem of too small skb->len -- https://patchwork.kernel.org/patch/11201179/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches