Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191022100420.25116-1-yhchuang@realtek.com> <20191022100420.25116-6-yhchuang@realtek.com>
In-Reply-To: <20191022100420.25116-6-yhchuang@realtek.com>
From:   Chris Chiu <chiu@endlessm.com>
Date:   Thu, 24 Oct 2019 09:33:25 +0800
Message-ID: <CAB4CAwdpG5yfEaptLjpMzsG4hCG+Qc9GpxRMkFHpKD7mwEPigw@mail.gmail.com>
Subject: Re: [PATCH v3 5/5] rtw88: add phy_info debugfs to show Tx/Rx physical status
To:     Tony Chuang <yhchuang@realtek.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Brian Norris <briannorris@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 22, 2019 at 6:04 PM <yhchuang@realtek.com> wrote:
>
> From: Tsang-Shian Lin <thlin@realtek.com>
>
> This commit adds several Tx/Rx physical information to phy_info
> debugfs for 8822B/8822C. By this debugfs, we can know physical
> information, such as Tx/Rx rate, RSSI, EVM,SNR, etc. The
> information is gotten from the packets of Tx/Rx path. It has
> no impact for the performance of 8822B/8822C.
>
> In the fields, we may meet different kinds of problems, but
> we may have no professional instrument to check them. At
> this moment, this debugfs is a good tool, and it may provide
> useful information for debug.
>
> Signed-off-by: Tsang-Shian Lin <thlin@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> ---
Reviewed-by: Chris Chiu <chiu@endlessm.com>

>
> v1 -> v2
>   * No change
>
> v2 -> v3
>   * refine get evm code, use S8_MIN
>
> --
> 2.17.1
>