Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2689968ybg; Thu, 24 Oct 2019 13:36:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/y1veN4uD8ByhaOnOFTQSAngt3Rw2rflOsNi3bmv50Bz/EVV0NCSWdGJ2ly4ldEjPw81a X-Received: by 2002:a17:906:1cce:: with SMTP id i14mr79264ejh.296.1571949416446; Thu, 24 Oct 2019 13:36:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571949416; cv=none; d=google.com; s=arc-20160816; b=R76YELnWqhpVJAVhx/dX9jyGLo7t8tgpRHh/i03EMwzLfDOARHEYDuCJhtMm2RR7ex z5FuNZ1vOUs9pevj6XOpo99Kso+VfnR2SBTz9Y9/kkHhWYuuhk4qNUjsHSCEhWpL0+Lm cYFbFQYXDWGy+z0hIH3B5hQqjT0pX/QYJtk4YiDM4exSyO57394w4RE96YeWLKzufsQp jd+AwTJVMj/sATGo07bHgUYGy5AgR1NDI45UNKHCHB+njbiUJ0U77YiIhbyyL2MYpEha tuibZg6dtbncNTIaMna1fdGv8KQjMrn7YgLMSh4Pygh1WKDQIJOzkmpS7eTaw0Q/9rYA FQ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=2cgaBnYz4a1qGwNBwfPw34bFfBPfd3lSFyIheuElHw8=; b=aIto5sgegnqdhmYdapR2J2JUfagfs3Iro4uY77IU1ghtXSazI+k/U9QHaPqMG0nz66 Dg1x9c3SelD+OHWa+XMYfg79virqEh+Ed6Qz6XDaTSVxPUhqlS0TLYpqib0eGp9M8+Q9 mdEjZav8ZzgZQdEmF4E5gnHuT6Bj10X2m7Sb8K3FDd/nh82PW33ixpC59fwcjGTZY9lm qslq58tQYhMUGelVmNB8y2JSpmJfggk/Lc/YrSaFtzpLCBVC7Yb3ZzulMDGgrzVEc0U8 DRtTblDjStgqrhGzH5AthSCtn+IaFCcRfMqVXbWnk6VMS9q1+lWMNskSD/3HEvVtfcwS fVRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@natalenko.name header.s=dkim-20170712 header.b=a+kth0dQ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=natalenko.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d28si8767005edb.10.2019.10.24.13.36.31; Thu, 24 Oct 2019 13:36:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@natalenko.name header.s=dkim-20170712 header.b=a+kth0dQ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=natalenko.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437707AbfJXGTJ (ORCPT + 99 others); Thu, 24 Oct 2019 02:19:09 -0400 Received: from vulcan.natalenko.name ([104.207.131.136]:41746 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403986AbfJXGTJ (ORCPT ); Thu, 24 Oct 2019 02:19:09 -0400 Received: from mail.natalenko.name (vulcan.natalenko.name [IPv6:fe80::5400:ff:fe0c:dfa0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by vulcan.natalenko.name (Postfix) with ESMTPSA id 229A060D3F2; Thu, 24 Oct 2019 08:19:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1571897946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2cgaBnYz4a1qGwNBwfPw34bFfBPfd3lSFyIheuElHw8=; b=a+kth0dQSGJ06qGmQi3wuwsnIvf3oGvwfZZBpAsRtonnY+BTfdRjUctnQbO5skefNMoLTa Vv3yip+Jl1EisyvkAKmZDNf2mi6fIbV2XyOYcnb6A815qZeMOYdZVZ4McA5CGGSAN827Je 4cLdcB77cKe1/ffbzD3reFFM09FnEuQ= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 24 Oct 2019 08:19:06 +0200 From: Oleksandr Natalenko To: Lorenzo Bianconi Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, nbd@nbd.name, sgruszka@redhat.com, lorenzo.bianconi@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH wireless-drivers 0/2] fix mt76x2e hangs on U7612E mini-pcie In-Reply-To: References: Message-ID: X-Sender: oleksandr@natalenko.name User-Agent: Roundcube Webmail/1.3.10 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi. On 24.10.2019 00:23, Lorenzo Bianconi wrote: > Various mt76x2e issues have been reported on U7612E mini-pcie card [1]. > On U7612E-H1 PCIE_ASPM causes continuous mcu hangs and instability and > so patch 1/2 disable it by default. > Moreover mt76 does not properly unmap dma buffers for non-linear skbs. > This issue may result in hw hangs if the system relies on IOMMU. > Patch 2/2 fix the problem properly unmapping data fragments on > non-linear skbs. > > [1]: > https://lore.kernel.org/netdev/deaafa7a3e9ea2111ebb5106430849c6@natalenko.name/ > > Lorenzo Bianconi (2): > mt76: mt76x2e: disable pcie_aspm by default > mt76: dma: fix buffer unmap with non-linear skbs > > drivers/net/wireless/mediatek/mt76/dma.c | 10 ++-- > drivers/net/wireless/mediatek/mt76/mmio.c | 47 +++++++++++++++++++ > drivers/net/wireless/mediatek/mt76/mt76.h | 1 + > .../net/wireless/mediatek/mt76/mt76x2/pci.c | 2 + > 4 files changed, 57 insertions(+), 3 deletions(-) Feel free to add my Reported-by: Oleksandr Natalenko Tested-by: Oleksandr Natalenko and thanks for the submission. -- Oleksandr Natalenko (post-factum)