Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 24 Oct 2019 10:08:50 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, nbd@nbd.name, sgruszka@redhat.com,
        lorenzo.bianconi@redhat.com, oleksandr@natalenko.name,
        netdev@vger.kernel.org
Subject: Re: [PATCH wireless-drivers 1/2] mt76: mt76x2e: disable pcie_aspm by
 default
Message-ID: <20191024080850.GA9346@localhost.localdomain>
References: <cover.1571868221.git.lorenzo@kernel.org>
 <fec60f066bab1936d58b2e69bae3f20e645d1304.1571868221.git.lorenzo@kernel.org>
 <87eez2u44r.fsf@kamboji.qca.qualcomm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm"
Content-Disposition: inline
In-Reply-To: <87eez2u44r.fsf@kamboji.qca.qualcomm.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>=20
> > On same device (e.g. U7612E-H1) PCIE_ASPM causes continuous mcu hangs a=
nd
> > instability and so let's disable PCIE_ASPM by default. This patch has
> > been successfully tested on U7612E-H1 mini-pice card
> >
> > Signed-off-by: Felix Fietkau <nbd@nbd.name>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>=20
> [...]
>=20
> > +void mt76_mmio_disable_aspm(struct pci_dev *pdev)
> > +{
> > +	struct pci_dev *parent =3D pdev->bus->self;
> > +	u16 aspm_conf, parent_aspm_conf =3D 0;
> > +
> > +	pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, &aspm_conf);
> > +	aspm_conf &=3D PCI_EXP_LNKCTL_ASPMC;
> > +	if (parent) {
> > +		pcie_capability_read_word(parent, PCI_EXP_LNKCTL,
> > +					  &parent_aspm_conf);
> > +		parent_aspm_conf &=3D PCI_EXP_LNKCTL_ASPMC;
> > +	}
> > +
> > +	if (!aspm_conf && (!parent || !parent_aspm_conf)) {
> > +		/* aspm already disabled */
> > +		return;
> > +	}
> > +
> > +	dev_info(&pdev->dev, "disabling ASPM %s %s\n",
> > +		 (aspm_conf & PCI_EXP_LNKCTL_ASPM_L0S) ? "L0s" : "",
> > +		 (aspm_conf & PCI_EXP_LNKCTL_ASPM_L1) ? "L1" : "");
> > +
> > +#ifdef CONFIG_PCIEASPM
> > +	pci_disable_link_state(pdev, aspm_conf);
> > +
> > +	/* Double-check ASPM control.  If not disabled by the above, the
> > +	 * BIOS is preventing that from happening (or CONFIG_PCIEASPM is
> > +	 * not enabled); override by writing PCI config space directly.
> > +	 */
> > +	pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, &aspm_conf);
> > +	if (!(aspm_conf & PCI_EXP_LNKCTL_ASPMC))
> > +		return;
> > +#endif /* CONFIG_PCIEASPM */
>=20
> A minor comment, but 'if IS_ENABLED(CONFIG_PCIEASPM)' is preferred over
> #ifdef. Better compiler coverage and so on.

Hi Kalle,

ack, I will fix it in v2.

Regards,
Lorenzo

>=20
> --=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches

--EVF5PPMfhYS0aIcm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXbFcEAAKCRA6cBh0uS2t
rGOtAQCGhErEs2zXuOOCpsKHdrNhCmZVXNfmNFRLzx3pvw7gAAD/Q+FCJo/TtLTT
5bx4h3MOKy8tD22nno2praFY8IJ8LwE=
=QH3z
-----END PGP SIGNATURE-----

--EVF5PPMfhYS0aIcm--