Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authenticated-By: 
From:   Tony Chuang <yhchuang@realtek.com>
To:     Kalle Valo <kvalo@codeaurora.org>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] rtw88: fix GENMASK_ULL for u64
Thread-Topic: [PATCH] rtw88: fix GENMASK_ULL for u64
Thread-Index: AQHVikxJCyqXv3HRNU+F6JfFe6i286dpkRaTgAABnAA=
Date:   Thu, 24 Oct 2019 10:13:59 +0000
Message-ID: <F7CD281DE3E379468C6D07993EA72F84D190F29C@RTITMBSVM04.realtek.com.tw>
References: <20191024091948.10569-1-yhchuang@realtek.com>
 <87ftjie9t3.fsf@tynnyri.adurom.net>
In-Reply-To: <87ftjie9t3.fsf@tynnyri.adurom.net>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> Subject: Re: [PATCH] rtw88: fix GENMASK_ULL for u64
> 
> <yhchuang@realtek.com> writes:
> 
> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >
> > This fixes compile warning:
> >
> >     In file included from include/linux/bitops.h:5:0,
> >                      from include/linux/kernel.h:12,
> >                      from include/asm-generic/bug.h:19,
> >                      from arch/mips/include/asm/bug.h:42,
> >                      from include/linux/bug.h:5,
> >                      from include/net/mac80211.h:16,
> >                      from
> drivers/net/wireless/realtek/rtw88/main.h:8,
> >                      from
> drivers/net/wireless/realtek/rtw88/main.c:5:
> >     drivers/net/wireless/realtek/rtw88/main.c: In function
> 'rtw_update_rate_mask':
> >       include/linux/bits.h:23:11: warning: right shift count is negative
> >       [-Wshift-count-negative]
> >        (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
> >                ^
> >     drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion
> of macro 'GENMASK'
> >       u64 cfg_mask = GENMASK(63, 0);
> >                      ^~~~~~~
> >
> > Fixes: f39e9bd49a3d ("rtw88: add set_bitrate_mask support")
> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> I'll add:
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> 

Yes, please add it, I forgot about it.
Thanks

Yan-Hsuan