Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4083903ybg; Fri, 25 Oct 2019 13:05:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOF4X+f6k44Ozy37e5lNVxGatLDisaw+ahSOsgZLpAIX+wlQ1RmWOfevlHqlejUr8Byjlz X-Received: by 2002:a50:97af:: with SMTP id e44mr6017354edb.3.1572033913446; Fri, 25 Oct 2019 13:05:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572033913; cv=none; d=google.com; s=arc-20160816; b=Lwbqlu3Y89Gwa0AfQYkFvgfb/gx16x3CZUNxJhdh0KOJJlgd/1pfJ870MdPdoCdZ+n AHN0LhASsceUzYPXD5J3Ki4CdNqR5XJVvG8tiHoAVq6Py0JIu/NFsecpZXEpsTPECMZX 5W79LfkIAmiZaEtv+S8W0UUb9TX9LczszVXpdKuB7jZNDNu2erS9IatJEj0W5Fd8Z3hr VbqXHOfC2PFnK+FzYauW3Hxhu+fQpLJyBMDpfwFTyrk3zfhnFEPMe5B7clPLQv1UCKNU uYZOM1Q460pXXC485slEEfojDuxXIJnXpnMqAFBTNjiO3jXZCDr73FsEND6rym99JmzW t3ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ZnkFkI43OhyFax4smGQ3szy9pZpk1SX3jWYT1yVJL+U=; b=qXUi93cs/CteGOVdaDPggWy9Tx5Ivr2HP0wdrZHMPKkopLjOsRqtN52IB4WOkcfGSh g1nU5TYYe1DyPlmgpL7kxIjCd/nM6nbQFElsWnbrWEzAHikh1N5x0yQrSo9Ma2esNEdJ 4jFgITaTybJCeL+8F/b03cmSMKYwxV+iL7h7BTOhiYvRcBIw1K4w2ohajID2eZFCves0 rvfTK9qoZAW936bcmsGV37NfO8VXO6iTAgeET8Z7f+bRW0IDW3bU/XL2zyyLAGSXY4Eu YkFPUDKqkSC9SxN7KX6nIRorMya6cdMWohjUrrcO3W+UnnwkkJRwaN5rSOFnQlt4P0h5 rIWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e13si1684004ejt.319.2019.10.25.13.04.38; Fri, 25 Oct 2019 13:05:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408201AbfJYMVT (ORCPT + 99 others); Fri, 25 Oct 2019 08:21:19 -0400 Received: from nbd.name ([46.4.11.11]:43310 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404706AbfJYMVS (ORCPT ); Fri, 25 Oct 2019 08:21:18 -0400 Received: from p5dcfbc27.dip0.t-ipconnect.de ([93.207.188.39] helo=bertha.fritz.box) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1iNyah-0000MS-C2; Fri, 25 Oct 2019 14:21:15 +0200 From: John Crispin To: Johannes Berg Cc: linux-wireless@vger.kernel.org, John Crispin , Miles Hu Subject: [PATCH] mac80211: fix VHT BW reporting inside ieee80211_add_tx_radiotap_header Date: Fri, 25 Oct 2019 14:21:05 +0200 Message-Id: <20191025122105.14577-1-john@phrozen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The pointer offset was not incremented after setting the BW value when reporting a VHT rate. This fixes commit 3d07ffcaf320 ("mac80211: add struct ieee80211_tx_status support to ieee80211_add_tx_radiotap_header") Reported-by: Miles Hu Signed-off-by: John Crispin --- net/mac80211/status.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac80211/status.c b/net/mac80211/status.c index f03aa8924d23..b036bf0269c2 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c @@ -406,6 +406,7 @@ ieee80211_add_tx_radiotap_header(struct ieee80211_local *local, *pos = 0; break; } + pos++; /* u8 mcs_nss[4] */ *pos = (status->rate->mcs << 4) | status->rate->nss; -- 2.20.1