Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4196011ybg; Tue, 29 Oct 2019 03:39:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwsLro5Ae8dmJSfa7Q8y1K0tK0u8m5o9lQaOgMerJbky20YYvSno6G3h2pAS7k4mvmg7mLq X-Received: by 2002:a17:906:7097:: with SMTP id b23mr2551345ejk.252.1572345553778; Tue, 29 Oct 2019 03:39:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572345553; cv=none; d=google.com; s=arc-20160816; b=OA5ZD8aYKV7/K28QcSyF8rjE4XLru1gov9kfp6Ycilh+8SgcBVnjAQD0ScXHFVrJRs 9Se8MtXpQPidJrE9SaVurgN94aTJg2Cjz2CluzVHbXgtjmTOYoH0+/jx4qPWOgSddFMC HgQTFZU6p/ZWtfkfCSwLjwz1Tyq2WqTorVAT3kcF+/+32Y2dtuMZToOsaTmjs+DtyNvl 3djA6fMQrBrQri33Gj30QGmRwf+m4YCwRyslFLIYcMCrgAPutHe+kNhoqSaqUCbjRDU5 wHNcDQcxWb46yliHVGHk73LY9JK6lx0FvGBblVEG6Xs+unFoJOhvSNqi5LUV7eYTnVax DVVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Dot7pMjC2BxzslmOlbGGuNCV9BZ/JqrIKhYQc3fevG0=; b=GLm9W2fSBt00eGGwoXOcbXGdN36vh4nYXi+pagP2SpygnvEEWceOTtgZ7mvf7Y+Up9 RwHn8cvzmHSUWno5uFO9C8wxIkW0Y+Emr8AIinyIZC4yDKIECpee/4VewJSc1144Y9KU FeNZ05u7Pb5iqBSWJ8K4SCJ0JbU49NPN1s7GrFITElVgw+dBuQP3vtWYeKDFxEdBBam8 vY6ZmAL5RWRopS8bLlZJZU5UpTpEC6w2w0nNAKv6HEY7xq2N5zUpdO3u34GnXLVIyhAo S/oUrvKdqHNjpWz6/DlmEhOmgulLX00nKBuOTLrwTwbsx0pTmWbOuKUD/6WZGwji2dej 9OBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gz21si7068480ejb.260.2019.10.29.03.38.49; Tue, 29 Oct 2019 03:39:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728609AbfJ2JiN (ORCPT + 99 others); Tue, 29 Oct 2019 05:38:13 -0400 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:43490 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfJ2JiM (ORCPT ); Tue, 29 Oct 2019 05:38:12 -0400 X-Greylist: delayed 460 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Oct 2019 05:38:12 EDT Received: from localhost.localdomain (unknown [141.24.212.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id E1CA058006C; Tue, 29 Oct 2019 10:30:30 +0100 (CET) From: Markus Theil To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Markus Theil Subject: [PATCH] nl80211: fix validation of mesh path nexthop Date: Tue, 29 Oct 2019 10:30:03 +0100 Message-Id: <20191029093003.10355-1-markus.theil@tu-ilmenau.de> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Mesh path nexthop should be a ethernet address, but current validation checks against 4 byte integers. Fixes: 2ec600d672e74 ("nl80211/cfg80211: support for mesh, sta dumping") Signed-off-by: Markus Theil --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index d1451e731bb8..7186cb653c75 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -393,7 +393,7 @@ const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = { [NL80211_ATTR_MNTR_FLAGS] = { /* NLA_NESTED can't be empty */ }, [NL80211_ATTR_MESH_ID] = { .type = NLA_BINARY, .len = IEEE80211_MAX_MESH_ID_LEN }, - [NL80211_ATTR_MPATH_NEXT_HOP] = { .type = NLA_U32 }, + [NL80211_ATTR_MPATH_NEXT_HOP] = NLA_POLICY_ETH_ADDR_COMPAT, [NL80211_ATTR_REG_ALPHA2] = { .type = NLA_STRING, .len = 2 }, [NL80211_ATTR_REG_RULES] = { .type = NLA_NESTED }, -- 2.23.0