Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9563E60F7A
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath: ath9k: Remove unneeded variable
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20191028204317.GA29468@saurav>
References: <20191028204317.GA29468@saurav>
To:     Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     ath9k-devel@qca.qualcomm.com, davem@davemloft.net,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12
Message-Id: <20191030151857.63E3360913@smtp.codeaurora.org>
Date:   Wed, 30 Oct 2019 15:18:57 +0000 (UTC)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Saurav Girepunje <saurav.girepunje@gmail.com> wrote:

> Remove "len" variable which is not used in ath9k_dump_legacy_btcoex.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Fails to build, always compile test your patches.

In file included from drivers/net/wireless/ath/ath9k/gpio.c:17:
drivers/net/wireless/ath/ath9k/gpio.c: In function 'ath9k_dump_legacy_btcoex':
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: error: 'len' undeclared (first use in this function); did you mean '_end'?
   len += scnprintf(buf + len, size - len,  \
   ^~~
drivers/net/wireless/ath/ath9k/gpio.c:502:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
  ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
  ^~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: note: each undeclared identifier is reported only once for each function it appears in
   len += scnprintf(buf + len, size - len,  \
   ^~~
drivers/net/wireless/ath/ath9k/gpio.c:502:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
  ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
  ^~~~~~~~~~~~~~~
make[5]: *** [drivers/net/wireless/ath/ath9k/gpio.o] Error 1
make[4]: *** [drivers/net/wireless/ath/ath9k] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2

Patch set to Rejected.

-- 
https://patchwork.kernel.org/patch/11216495/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches