Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1070902ybx; Wed, 30 Oct 2019 09:24:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqypVQH4Is7qb2G1HmlHr4bu9FNX7xE/xyEGItB82uJjhHIMl5jUgI1qVAihQ0U3tURUs64J X-Received: by 2002:a17:906:6bcd:: with SMTP id t13mr320389ejs.231.1572452654577; Wed, 30 Oct 2019 09:24:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572452654; cv=none; d=google.com; s=arc-20160816; b=ynRGdDC4dXZAsZcBVIYnBqHG+ndS2SCD0YJcEwZRwXi8ZZsLPFzBdvZoei2q+RTFx+ 2SUFdLGHNaoaQNNhZV1zhx41nzwQaIr7PDvRWbw1JNUNNZwfyz8tU7T6X8DmZ22NK0S7 +yYJF1/FsGb28rHBFUJ4pnEpIiIm+R83ezRfnd5PDWR+dfbzeakAv6NeLvkra00QVwZS s84okQ/g8QWPGBlgmL71DDdDBL2uksRMQX9p0jSnPjuky8zoTR3vo34dm1pAPHifi7jK Qr2bECStoIpLr4ATG6UK71FrZ9T3MOkX6bBWaGIHtxOftNqSP3PwiLHUawacSsaiIasT 5iIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Rb/x1ONrPA2ACBm+71NRPr1xqWmnxoQN+Bjddk5BR4E=; b=MreBFWl5FXXVJphS+Sx7qkZiKybGy50+mE9RqiR2PwKgJMBIBziiU/4MFZvSHrM365 +DewxT5KjMLy9mrzi5npUT7K0PmyF0XHhFkT5AV8IL8ZHNf0oALB9ds52PBw39KyrZV8 WYOxx0unIqXRZY6HAQ6ZxErLDaXZUskQqjMB/KyssfxpCjiELLlYHJEiW/f8Cnk8diul gCAJdXzzk5VouS3OQHyMbzv77PZsqLOLXJq6T8QiZWx1yxEnbJpBliTAgYtu+UQideYa SD/j7vB4Basdrnlx0eMJPf6v3RnF/hib9xcMZZBjJRqcjjntA8a+9srxX3JT6JFQa6Cj 1FuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=HFmIA9qj; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8si1605275ejx.85.2019.10.30.09.23.43; Wed, 30 Oct 2019 09:24:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=HFmIA9qj; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727330AbfJ3QW7 (ORCPT + 99 others); Wed, 30 Oct 2019 12:22:59 -0400 Received: from mx3.wp.pl ([212.77.101.9]:9509 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726784AbfJ3QW7 (ORCPT ); Wed, 30 Oct 2019 12:22:59 -0400 Received: (wp-smtpd smtp.wp.pl 6876 invoked from network); 30 Oct 2019 17:22:51 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1572452572; bh=Rb/x1ONrPA2ACBm+71NRPr1xqWmnxoQN+Bjddk5BR4E=; h=From:To:Cc:Subject; b=HFmIA9qjcUbLBKRyEtajpXt3QdAAQ4PaGDkIzZ5aMmGzhSGgios49tM3C/aYGasVr c88/nywPwI+seB1W4IWNImxredaFgrOhKC+Vfnb5YgcyoTHge9DEaZSYQHW40OgMvc NeWmuymwrxKNhNvmoY+A04GqfikMki2EX5E9aIyA= Received: from c-73-202-202-92.hsd1.ca.comcast.net (HELO cakuba.hsd1.ca.comcast.net) (kubakici@wp.pl@[73.202.202.92]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 30 Oct 2019 17:22:51 +0100 Date: Wed, 30 Oct 2019 09:22:47 -0700 From: Jakub Kicinski To: zhong jiang Cc: , , , , Subject: Re: [PATCH] mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops Message-ID: <20191030092247.71e24bfe@cakuba.hsd1.ca.comcast.net> In-Reply-To: <1572422924-58878-1-git-send-email-zhongjiang@huawei.com> References: <1572422924-58878-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: b6401afc017796d6907f1950e05fd291 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [8XNk] Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 30 Oct 2019 16:08:44 +0800, zhong jiang wrote: > It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file > operation rather than DEFINE_SIMPLE_ATTRIBUTE. > > Signed-off-by: zhong jiang Acked-by: Jakub Kicinski