Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <c20b5712d610b58bf153ba4aa6ed5f2764af424d.camel@sipsolutions.net>
Subject: Re: [PATCH 1/1] sta_info: fix insane values in iw sta dump
 "inactive time"
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Ahmed Zaki <anzaki@gmail.com>, linux-wireless@vger.kernel.org
Date:   Thu, 31 Oct 2019 09:11:11 +0100
In-Reply-To: <20191030213153.3196-2-anzaki@gmail.com> (sfid-20191030_223241_218733_F012DFCA)
References: <20191030213153.3196-1-anzaki@gmail.com>
         <20191030213153.3196-2-anzaki@gmail.com>
         (sfid-20191030_223241_218733_F012DFCA)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, 2019-10-30 at 15:31 -0600, Ahmed Zaki wrote:
> In the first 5 mins after boot (initial jiffies),
> ieee80211_sta_last_active() returns zero in case last_ack is zero. This
> leads to insane values appearing in "inactive time".
> 
> Fix by returning last_rx if last_ack == 0.

Please read

https://wireless.wiki.kernel.org/en/developers/Documentation/SubmittingPatches

johannes