Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <e18ba5a1e71561223677243efb19561be55d0f30.camel@sipsolutions.net>
Subject: Re: [PATCH v2] mac80211: fix insane values that sometimes appear in
 inactive_time
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Ahmed Zaki <anzaki@gmail.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 31 Oct 2019 13:23:48 +0100
In-Reply-To: <20191031121243.27694-1-anzaki@gmail.com> (sfid-20191031_131303_213675_40076E91)
References: <20191031121243.27694-1-anzaki@gmail.com>
         (sfid-20191031_131303_213675_40076E91)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-10-31 at 06:12 -0600, Ahmed Zaki wrote:
> In the first 5 minutes after boot (time of INITIAL_JIFFIES),
> ieee80211_sta_last_active() returns zero if last_ack is zero. This
> leads to "inactive time" showing jiffies_to_msecs(jiffies).
> 
>  # iw wlan0 station get fc:ec:da:64:a6:dd
>  Station fc:ec:da:64:a6:dd (on wlan0)
> 	inactive time:	4294894049 ms
> 	.
> 	.
> 	connected time:	70 seconds
> 
> Fix by returning last_rx if last_ack == 0.
> 
> Signed-off-by: Ahmed Zaki <anzaki@gmail.com>

Thanks for the updates :)
 
> -	if (time_after(stats->last_rx, sta->status_stats.last_ack))
> +	if (!sta->status_stats.last_ack ||
> +		time_after(stats->last_rx, sta->status_stats.last_ack))
>  		return stats->last_rx;

The indentation is still wrong :)

I guess I could fix that too.

johannes