Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1558554ybx; Sat, 2 Nov 2019 02:02:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBqA5HDjUSv723ZOCQVTFnVoDpFDgHpY+Q0HjSRoBqPmR9sz6LVI9OccZMMgZLLq+2R9qp X-Received: by 2002:aa7:c358:: with SMTP id j24mr18038392edr.147.1572685345232; Sat, 02 Nov 2019 02:02:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572685345; cv=none; d=google.com; s=arc-20160816; b=YOOKC2fY0p7XvMuEexb6Bycg08aran6jqnTZoejBzzsnElNrhkCwg4XP3UlagOt8oG KuICzB0b3EBmsnapPwcXILE5unGef1QC7+J6YpQhhWQAIov9poLZl32ON7AosJpj0IY9 ENXZ5zNWwmB4xempVvlKNtc9342qU65UrBAQAn2g5sjXI6YJ/gH1pBT1LpcC4DpfJ1eH IXg2kPfFasGbLXxTvLc10FDSpt2Iq3vXHwq6aF8HQdqf5VL5/g1KIYZJA/u5BCceKhLK xBGN3Rq1VpFTXUMllc7hcYGCR+fdzzFjZm6QBveZLCclIIrlJgtZEMSIAqbMg4oo+Yx3 LrgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=4n1i9I+iR9IcnaGI7/0yvS04cmcfF2dF4/NomqWRLos=; b=Njk1ree8eIRkW+sLlEwCPaUQb5DGDeZZAS1UB8EGIbYYUZEK59ONZRKAaNxIZr1vwj 0udq1LILxwP/C9LKLrulUzjAzfTut9iZQQ/Ffjejo93tykzObboZJGLfJFl7WwILWgh0 F3fJSyt+CkO5LjD1eU9OQ3VMIo1+yiDKGvMd2EiwnYaV0YI7uZFmjDfW3B/Hrj2/LdAa tMxF1zaGAX8oVOpMdcHHTtPYKPdt1xAlPdK1P3zWeb9LXTbrKrZJ+UkqouVpTzN1lBzH V37SVDQo42oslcCedpZqu6yUZ8lrV/a6FraLh1mgxu24uKLpuu6WZ+9DPLvrSNVKLoJu PiAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si7582229eju.132.2019.11.02.02.02.01; Sat, 02 Nov 2019 02:02:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbfKBI7b (ORCPT + 99 others); Sat, 2 Nov 2019 04:59:31 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:41774 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727052AbfKBI7b (ORCPT ); Sat, 2 Nov 2019 04:59:31 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 4999FB6C81768D9A4095; Sat, 2 Nov 2019 16:59:27 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.439.0; Sat, 2 Nov 2019 16:59:18 +0800 From: zhong jiang To: , , CC: , , Subject: [PATCH v3 2/2] iwlegacy: Remove redundant variable "ret" Date: Sat, 2 Nov 2019 16:55:22 +0800 Message-ID: <1572684922-61805-3-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1572684922-61805-1-git-send-email-zhongjiang@huawei.com> References: <1572684922-61805-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org local variable "ret" is not used. hence it is safe to remove and just return 0. Signed-off-by: zhong jiang --- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c index 51fdd7c..3664f56 100644 --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c @@ -3331,7 +3331,6 @@ struct il_mod_params il4965_mod_params = { struct ieee80211_key_conf *keyconf, u8 sta_id) { unsigned long flags; - int ret = 0; __le16 key_flags = 0; key_flags |= (STA_KEY_FLG_TKIP | STA_KEY_FLG_MAP_KEY_MSK); @@ -3368,7 +3367,7 @@ struct il_mod_params il4965_mod_params = { spin_unlock_irqrestore(&il->sta_lock, flags); - return ret; + return 0; } void -- 1.7.12.4