Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3676137ybx; Mon, 4 Nov 2019 00:49:41 -0800 (PST) X-Google-Smtp-Source: APXvYqxM0gkUom+9MmqYRDCRjCZ4yuFi3p9Gz1sPVxZpuD9KSxINeIUK2d5Vy4gLLJVNn5cUhLFt X-Received: by 2002:a50:88a6:: with SMTP id d35mr28279807edd.111.1572857381001; Mon, 04 Nov 2019 00:49:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572857380; cv=none; d=google.com; s=arc-20160816; b=AOrLc+e6FB6i6H5o8kfQA8A0lGqkTnID0sCjQBricYS65Cek+M8uKfAMKO+wYZDMCe IUmeQGiC+JR/3LSJbOyKRMKI82TRExayW8yvZ8n0FiUa2s7KGoBavuvAJsQ+ghkaMTgY 1JQt6KYsNGco6ZeOBCIFs0xiflMxBc4mdRNrJOAWawFHyAcRPzEN6BXuRxAq8wo03VGp dyJ40IiKH6vjjl+LliXQDdftLpvNRT2iBCnwg+bNQnagTffu1BgHAZfr2I4KQVdrJHZ9 UIVH3jJVLKPsOpiWPCYz8N5iBe2t+lrNkyWQJ/UJgn7tHRx97kwooYKkj7NFDOFkH3KP z60g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:user-agent:in-reply-to:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FcGnEGbP2nkjgsroFu4oivDfxSL+0B07LjsyFwj30H0=; b=IzVkin+FNttWdN5qOujukhEZn9ZTnLBIlc1Nkm8dnBES955DmQHKMOIAVHpN5GeemW 09W9eygBAOIai06gduX+ekPU8V2OK70xUJ68XKxZwQBiPGUeYU1HZBpUUl4RfsNfJuMx HoazooRVssNIZur3iCqPGPuWW3oJatBtXYALvsxPDVSw417xhOHzJVyP6vkzpeNBJ8A9 42r87WuTlskoBp7RmK05I2t7PiwDYLccn7Kha/wz48C0tSWeeAwpqSS4A8CJr9BYrxpl WU44cuZB5bLPxz0kOXzbEjVbfT6lSCH7BGaFld3R8A8t+qHyEqzKt9zPHjdE6nZO7Sj3 6W5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="c/mhHyKt"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e19si512939ejb.379.2019.11.04.00.49.09; Mon, 04 Nov 2019 00:49:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="c/mhHyKt"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbfKDIsf (ORCPT + 99 others); Mon, 4 Nov 2019 03:48:35 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:58266 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726100AbfKDIsf (ORCPT ); Mon, 4 Nov 2019 03:48:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572857314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FcGnEGbP2nkjgsroFu4oivDfxSL+0B07LjsyFwj30H0=; b=c/mhHyKtsR+tizIZLi49nY/ld+ycIGZpxo3aIaEC/9KpO1Q5FM2W8M+MuX3iZCk9godWOd myhQ0lfZgS87r9cccsIF2WEdG4/B5cEF0WwIBZ8GGd5e1L3bSR67lAvEnEkuNkkwTXsi46 gjodZuA9Qf8JMCFWucYNC35aVs/gjWM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-56-Wsu3YPidPQq40bkMNbrDWw-1; Mon, 04 Nov 2019 03:48:31 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C393800686; Mon, 4 Nov 2019 08:48:29 +0000 (UTC) Received: from localhost (unknown [10.43.2.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id A1A115D6C8; Mon, 4 Nov 2019 08:48:25 +0000 (UTC) Date: Mon, 4 Nov 2019 09:48:23 +0100 From: Stanislaw Gruszka To: Tom Psyborg Cc: Daniel Golle , linux-wireless@vger.kernel.org, Roman Yeryomin , wbob Subject: Re: [PATCH] rt2800: remove erroneous duplicate condition Message-ID: <20191104084823.GA2306@redhat.com> References: <20191028212244.GA2590@makrotopia.org> <20191029091857.GB3571@redhat.com> <20191029100503.GA1228@makrotopia.org> <20191102154639.GA4589@redhat.com> <20191102174227.GA1250@makrotopia.org> <20191103144749.GA8889@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: Wsu3YPidPQq40bkMNbrDWw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, Nov 03, 2019 at 04:41:11PM +0100, Tom Psyborg wrote: > On 03/11/2019, Stanislaw Gruszka wrote: > > On Sat, Nov 02, 2019 at 06:42:27PM +0100, Daniel Golle wrote: > >> > This was changed by: > >> > > >> > commit c2e28ef7711ffcb083474ee5f154264c6ec1ec07 > >> > Author: Tomislav Po=C5=BEega > >> > Date: Thu Dec 27 15:05:25 2018 +0100 > >> > > >> > rt2x00: reduce tx power to nominal level on RT6352 > >> > > >> > and I think it is correct. > >> > >> Ah, ok, that's a bit funny, because it means that this change actually > >> never made any difference, because the codepath wasn't executed. > > > > Yes, this was used/tested on patched rt2x00 driver that switch to this > > different codepath. Now it will be used by default :-) > > > > Stanislaw > > > > >=20 > Hi >=20 > For your reference: rt2x00: reduce tx power to nominal level on RT6352 >=20 > iPA/eLNA - fixes too high power output > ePA/eLNA - doesn't have any effect > iPA/iLNA - not tested Does someone have iPA/iLNA device so this can be tested? Or it is not used combination on available devices?=20 Stanislaw