Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3699208ybx; Mon, 4 Nov 2019 01:16:27 -0800 (PST) X-Google-Smtp-Source: APXvYqxEKjXwytohlU/x7iJQc1AjrQrF6flkqygKxLSESdbOkgPmsZCSlReRZ0/8nniaBaF2MK3L X-Received: by 2002:a17:906:5e52:: with SMTP id b18mr9639802eju.318.1572858987696; Mon, 04 Nov 2019 01:16:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572858987; cv=none; d=google.com; s=arc-20160816; b=UqEaJRuB1U5YI4gNc1Kf4fnajfiWP4x1MmhVQSktJpoC+fcttOZvmHlpH3Y6ApYS2h b50Q40WBWkKiCpMXPTKaceXxne+JiSTjZjFLaEZPLE0N+YKN9yyJxg8rk3JvrG5g8bO0 v1UffcJGr8wQBbqtZQWNBeWWVIe4zvt9HbZHAFDGov97zzRcBt8OR7Ab2s8CwOeZADG6 uTPd5sBVkyPpGAfS/FuCGqGJ0yBZnlcTnzNYX5/ZQiEzQjB6balsX724oaRlQZvGLKy/ R4tmhW/Ywxf5ZSxRIfLiXewnR3/62diJtpVioU24sezjQYIEN+Xqz4Y++iSCRS9Y8UIu nieQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:user-agent:in-reply-to:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9DB5gp+ro/GtJFv0UTXR5fBfRs7JWr9kfJxMjyEATaw=; b=042NB2qarRLx0tjKD4jKkpx+J2YSUW0Is++Zd4f6Sxp984vrEOm4hDP8e8WE0PFMWV bFHRJU6/jUPvtGViunB6+9WbJ9S+z4RpAN53+Lp0LKSPynluPKhxFoS3waS7Kz28glmt O0Or7NDicyoCnm0dHBpgAzN78TzIx9pbsQHrZSEt/mfVlSn9YxPCnL7XFQzDXm8ipK89 FEP0OUq6kns9500kuO3AcsXyqIA+bZiHQJFLbVTTedoMRe7pk1KRA4gP6Yi/nfvuT2HD ra1hXJXXZ6F8D3qWtAEhLjht0baQyWXwXgWm+eliJXFJwAJF/SHKTzW/aZEV9BGoUyau S2IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K6Ihqe4T; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e56si6817122edb.172.2019.11.04.01.15.56; Mon, 04 Nov 2019 01:16:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K6Ihqe4T; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbfKDJPg (ORCPT + 99 others); Mon, 4 Nov 2019 04:15:36 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:41228 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726100AbfKDJPg (ORCPT ); Mon, 4 Nov 2019 04:15:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572858935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9DB5gp+ro/GtJFv0UTXR5fBfRs7JWr9kfJxMjyEATaw=; b=K6Ihqe4TM1ug4FYyRVmgjEZmP1jJfE9iZ0xY5r5qLRL07rGOTEKC/wEsY97E2ZGMdHrEYz 7Cnm82q8UY0S8/fJw3LAipatI3k1/6qTBlFY3BzOmJYdlC+7nXT7MOj/FW0or048GvYTMH ifUMNyLd7crnvgQHORKARgtulCPwLH0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-126-Yiiu9OZ3NCOtE7E8ABokzQ-1; Mon, 04 Nov 2019 04:15:31 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7F4A8017DD; Mon, 4 Nov 2019 09:15:29 +0000 (UTC) Received: from localhost (unknown [10.43.2.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68BF25C28D; Mon, 4 Nov 2019 09:15:28 +0000 (UTC) Date: Mon, 4 Nov 2019 10:15:26 +0100 From: Stanislaw Gruszka To: Daniel Golle Cc: Tom Psyborg , linux-wireless@vger.kernel.org, Roman Yeryomin , wbob Subject: Re: [PATCH] rt2800: remove erroneous duplicate condition Message-ID: <20191104091525.GB2306@redhat.com> References: <20191028212244.GA2590@makrotopia.org> <20191029091857.GB3571@redhat.com> <20191029100503.GA1228@makrotopia.org> <20191102154639.GA4589@redhat.com> <20191102174227.GA1250@makrotopia.org> <20191103144749.GA8889@redhat.com> <20191104084823.GA2306@redhat.com> <20191104090058.GA1258@makrotopia.org> MIME-Version: 1.0 In-Reply-To: <20191104090058.GA1258@makrotopia.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: Yiiu9OZ3NCOtE7E8ABokzQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Nov 04, 2019 at 10:00:58AM +0100, Daniel Golle wrote: > On Mon, Nov 04, 2019 at 09:48:23AM +0100, Stanislaw Gruszka wrote: > > On Sun, Nov 03, 2019 at 04:41:11PM +0100, Tom Psyborg wrote: > > > On 03/11/2019, Stanislaw Gruszka wrote: > > > > On Sat, Nov 02, 2019 at 06:42:27PM +0100, Daniel Golle wrote: > > > >> > This was changed by: > > > >> > > > > >> > commit c2e28ef7711ffcb083474ee5f154264c6ec1ec07 > > > >> > Author: Tomislav Po=C5=BEega > > > >> > Date: Thu Dec 27 15:05:25 2018 +0100 > > > >> > > > > >> > rt2x00: reduce tx power to nominal level on RT6352 > > > >> > > > > >> > and I think it is correct. > > > >> > > > >> Ah, ok, that's a bit funny, because it means that this change actu= ally > > > >> never made any difference, because the codepath wasn't executed. > > > > > > > > Yes, this was used/tested on patched rt2x00 driver that switch to t= his > > > > different codepath. Now it will be used by default :-) > > > > > > > > Stanislaw > > > > > > > > > > >=20 > > > Hi > > >=20 > > > For your reference: rt2x00: reduce tx power to nominal level on RT635= 2 > > >=20 > > > iPA/eLNA - fixes too high power output > > > ePA/eLNA - doesn't have any effect > > > iPA/iLNA - not tested > >=20 > > Does someone have iPA/iLNA device so this can be tested? > > Or it is not used combination on available devices?=20 >=20 > iPA/iLNA the most commonly found combination in cheap devices. > iPA/eLNA is more rare, but found in some higher-quality devices. > ePA/eLNA is available mostly in markets which allow higher TX power. > ePA/iLNA haven't seen it yet, but theoretically possible. >=20 > Looking at the internal photos of Nexx WT3020, I'm very certain this > is an iPA/iLNA device -- apart from regulators, magnetics, MT7620N > itself and flash memory, another magnetics and RAM on the backside, > there are no other parts on the board. Also afaik MT7620N only supports > iLNA/iPA (due to the limited number of pins of the DRQFN package). With the change on WT3020 I observed better RX throughput and more or less the same TX throughput. Not sure why, since the settings is about TX? I'll do more test, but so far Tom's change looks like good improvment for me. > See: > https://apps.fcc.gov/eas/GetApplicationAttachment.html?id=3D2241504 I get 'You are not authorized to access this page.' :-/ Stanislaw