Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4135006ybx; Mon, 4 Nov 2019 08:21:50 -0800 (PST) X-Google-Smtp-Source: APXvYqwRUNf4JXBrRo9vnBu0xM+sHnkgPRdX4zsyxNBmQ+2S/ZTpNEcIOT7/tavC4ixfoNpuJ16/ X-Received: by 2002:a17:906:7f94:: with SMTP id f20mr25201428ejr.333.1572884510868; Mon, 04 Nov 2019 08:21:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572884510; cv=none; d=google.com; s=arc-20160816; b=hvUD8LafJZWJ85mC4U+Vwp/wTc5BLBEcoGViU94DDqR1gxfd9MVhRmdYspKXPi69SK E9JFBuQRLcXuMfQaE+1VwWCSr48Rr0RXD38tjQyPkpAwZV6t2Az6mdoPgiU9mis89Pyv h4K3TI6ksUcLpt8GflsWdNSEa4KVSsr2lcPGuwgWuC+PQuVq67kVYHkMFMqiWrZOApIO MPD0kndXEZQKx3yFKVhZoB4ltmfsPKa1/ixgHiOz9pmx7S8DA4xyvYJH08q6WEWPM/HL HEncuW6/38eUO/JVhJyd2KSAmRarfmqjEplVeKHpJC/mjXHDFCjowmpndek7SLoRdybg r8jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=8Znuaex5+hszWISQ+Hp8i6X+TSyjA482lHnrCHBaKLc=; b=T8fG5kJSkcyK6ODWyy929sm7j1uI9630fh4pByG6qNrlq3Owqi4IrH7nGsd/rmQkw2 64PFTxDQMoUdgURT73u+c84ZaPJtpmDh6hm+FwYfcKAQx3wd7GpVaX0HslyfE/c/XKV/ 1wK5XMKuT7+xS10YwdsorNU8aZ1IxUkKDJxFgvQE+boFKlKh7cWil/nUa/+P0dRdUVmj qgZ7rgdFASIiXqLUU2jfjaQ8r5sAQOyP5Wxf+MMQE6ux0MJrH1kPxiEbKqOlMqPX67Ax Uz0vp02EF3HxvRFEB+yMGCIqftPhS+j8/IZIQw/7jnxeEO9dnu2xiX3baU+MyWgW2Uf6 iaYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=RYthr5rF; dkim=pass header.i=@codeaurora.org header.s=default header.b=mtvTztmh; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h90si8260663edd.178.2019.11.04.08.21.25; Mon, 04 Nov 2019 08:21:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=RYthr5rF; dkim=pass header.i=@codeaurora.org header.s=default header.b=mtvTztmh; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728843AbfKDQVC (ORCPT + 99 others); Mon, 4 Nov 2019 11:21:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33844 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727989AbfKDQVC (ORCPT ); Mon, 4 Nov 2019 11:21:02 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AE8A160300; Mon, 4 Nov 2019 16:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572884461; bh=mAwYNNw6CkSSmB+D5DesrCl5qikS8Btrviv8uSniBiw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RYthr5rFb1fViuvMm/4B9R0j0qAFTI/Ut4fOf3sk9TFqrTh263EL/tbRbS0e4zT1T oLnn6dQ3+4J/S/fugiA4dLMERpyiO/Fqkmny8lQAbV0sd0o/ulJe+V49c4qweCMeJl 1AVQSxZHxoFy0jlmtmNoOhV67R456+Uhux62E9tY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 174A660300; Mon, 4 Nov 2019 16:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572884460; bh=mAwYNNw6CkSSmB+D5DesrCl5qikS8Btrviv8uSniBiw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mtvTztmhvQZDJ1BHqKrPMUgw+OjXuX6xk4VIr7zrnutzmGDoFdptWnhqJJOfrZtCH i/AQrLFUzysUqWLzlMn/VX2gxu1YdC7fGc9Z0sAFPfjeGFHvf0I0NW7DCcfbp6Idsh aKzEpRYvE2LqrtHY3u4A47W/fWHYzGedB4kcdNbY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 174A660300 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: zhong jiang Cc: , , , Subject: Re: [PATCH v3 0/2] wireless: remove unneeded variable and return 0 References: <1572684922-61805-1-git-send-email-zhongjiang@huawei.com> Date: Mon, 04 Nov 2019 18:20:56 +0200 In-Reply-To: <1572684922-61805-1-git-send-email-zhongjiang@huawei.com> (zhong jiang's message of "Sat, 2 Nov 2019 16:55:20 +0800") Message-ID: <87a79b7guv.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org zhong jiang writes: > The issue is detected with help of coccinelle. > > v2 -> v3: > Remove [PATCH 3/3] of series. Because fappend will use the > local variable. You really need to test your patches. If you submit patches without build testing I'm not going to take such patches. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches