Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp482993ybx; Tue, 5 Nov 2019 00:24:51 -0800 (PST) X-Google-Smtp-Source: APXvYqyP9/fyqmYjcl4X3mNjhk/12tthdXjBtQPZ4yqopm1roZ/aTOO9Shz1OC9bERI8AaJhP6OD X-Received: by 2002:a17:906:1611:: with SMTP id m17mr28933590ejd.281.1572942291548; Tue, 05 Nov 2019 00:24:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572942291; cv=none; d=google.com; s=arc-20160816; b=qDTK+Kf94wYCRKTzg0QsmcHCZZOtsAp3Et1tW1At75frDYNxCZlyDj4R3HYi14KaWz CthfKQNpQH3G2CYsbnusKVpUw7uSKTRs2E/ixk5Vcdmdj0RduALP7xMKKWCXDotrQngd +sNxGl9L4UoMRb2jF2gNAfy2yhe8fQMvhzr5oZDztNXd0XXSFp1XAwYFXPHtb3/DU8Bh RPnwtiWlMts2mzjKO78lnyKAasK6TnPKB7bjRKm8UvVLhrhSXYoFN4tThh8Q81yIbOY2 15qDqqZS7JlxMql+zhwwDRalT9C7UIysVmXJTAPynwy739B9n5bo45slrALPpPfHw5LG zxBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=TYWNMiU731GCkaGHHU4yWtnh249EdBUdElZ+01loTF0=; b=PpEZ9m6mKbw0M9gbf7x4cyKcv46O9ljEh9yUvdL/TjWtMRS8cd31IIAKn3ldd2h2l8 jwOkdq5h/Zrog4n7f0mubjCg7wr2o2Zt0DypcO9PeJMt4gwXyAji6b0VMgctuKT+tYHM keZCr4gan8K9heQXtUBVlyHIziLRqJMeYgzfMXYmgd7VtQfQfZvUBchwWZmwbagZhBDT SmqHq6J8bk7yLCuueoDVbGjXPKE8xCMzTmbuioiog9R/syiJtzDAqGVTdCQZ5hfnr3Wq l5xiXQK6C3F2vLM7Tj1lThIhN9+A4G5zXeJo01Mp2tmpTOsFY1kKBhGtYM/7e1ycqmt3 OY0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="h3OE6/f3"; dkim=pass header.i=@codeaurora.org header.s=default header.b=dprY15Uf; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14si10202091edj.225.2019.11.05.00.24.14; Tue, 05 Nov 2019 00:24:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="h3OE6/f3"; dkim=pass header.i=@codeaurora.org header.s=default header.b=dprY15Uf; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387717AbfKEIVU (ORCPT + 99 others); Tue, 5 Nov 2019 03:21:20 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:44954 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387484AbfKEIVU (ORCPT ); Tue, 5 Nov 2019 03:21:20 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 750706090F; Tue, 5 Nov 2019 08:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572942079; bh=nAwjlRAFrDcHiDhUYKUDdNV1rAmHzr+VDZqV5W/gC34=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h3OE6/f3S+RriteokA3Gsl8C4qXVA4BeR25QEk/V1pWZEUsCc1jdruOv+qsnSdvmk 3EpqPhpaamhXmSTtoUjToBDX+4acQY2Av2jz+9loBj1nd74B3msHTD/5UADTbdMELC ZGIPreG0DTq2gLdV3kbEUVkFhu0xMJBQfMXBhm2o= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 97E396090F; Tue, 5 Nov 2019 08:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572942078; bh=nAwjlRAFrDcHiDhUYKUDdNV1rAmHzr+VDZqV5W/gC34=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dprY15UfLbDXdzkIw9yLVg4si8vP681VlRogtyiVbBu6/P7v4s2NkfHk2Pc8IurNC QoXIuNsMwGppdloPnPss9K/22sBoJpGbG0vtq2azTQP9ctAGD7N7iI7Wy5Cj5E45RV Pqjlt+yL2ssAA3KYFofCtiwuSVVklFFEsmBhaYIU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 97E396090F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Stanislaw Gruszka Cc: linux-wireless@vger.kernel.org, Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Roy Luo Subject: Re: [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E" References: <1572860780-2403-1-git-send-email-sgruszka@redhat.com> Date: Tue, 05 Nov 2019 10:21:13 +0200 In-Reply-To: <1572860780-2403-1-git-send-email-sgruszka@redhat.com> (Stanislaw Gruszka's message of "Mon, 4 Nov 2019 10:46:20 +0100") Message-ID: <87eeymd98m.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Stanislaw Gruszka writes: > This reverts commit 34b0e9b767bfa09ae233ca0d6ceb299bf2e24600. > > Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs") > is no longer necessary to disable HW encryption for MT7630E. > > Disabling HW encryption helped previously because somehow fragmented > skb's are not created if mac80211 encrypt frames, so buffer unmap bug > of non-linear skbs was not triggered. Now since this bug if properly > fixed by 7bd0650be63c , we can enable HW encryption back. This should be: ... fixed by commit 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs"), we can enable ... -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches