Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BB95460FF6
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
        Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>
Subject: Re: [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E"
References: <1572860780-2403-1-git-send-email-sgruszka@redhat.com>
        <87eeymd98m.fsf@tynnyri.adurom.net> <20191105090043.GB4422@redhat.com>
Date:   Tue, 05 Nov 2019 11:13:31 +0200
In-Reply-To: <20191105090043.GB4422@redhat.com> (Stanislaw Gruszka's message
        of "Tue, 5 Nov 2019 10:00:44 +0100")
Message-ID: <87woceznwk.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Stanislaw Gruszka <sgruszka@redhat.com> writes:

> On Tue, Nov 05, 2019 at 10:21:13AM +0200, Kalle Valo wrote:
>> Stanislaw Gruszka <sgruszka@redhat.com> writes:
>> 
>> > This reverts commit 34b0e9b767bfa09ae233ca0d6ceb299bf2e24600.
>> >
>> > Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")
>> > is no longer necessary to disable HW encryption for MT7630E.
>> >
>> > Disabling HW encryption helped previously because somehow fragmented
>> > skb's are not created if mac80211 encrypt frames, so buffer unmap bug
>> > of non-linear skbs was not triggered. Now since this bug if properly
>> > fixed by 7bd0650be63c , we can enable HW encryption back.
>> 
>> This should be:
>> 
>> ... fixed by commit 7bd0650be63c ("mt76: dma: fix buffer unmap with
>> non-linear skbs"), we can enable ...
>
> I provided the topic in the first reference of the commit at the top.
> Should I do this anytime in the chenglog when a commit is referenced,
> even if it's done already ?

Sorry, I missed that. Yes, you are right and ignore my comment.

-- 
Kalle Valo