Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 5 Nov 2019 10:52:27 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Petr =?utf-8?Q?=C5=A0tetiar?= <ynezz@true.cz>
Cc:     Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org,
        Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
        Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>
Subject: Re: [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for
 MT7630E"
Message-ID: <20191105095226.GC4422@redhat.com>
References: <1572860780-2403-1-git-send-email-sgruszka@redhat.com>
 <87eeymd98m.fsf@tynnyri.adurom.net>
 <20191105090043.GB4422@redhat.com>
 <20191105090845.GP22393@meh.true.cz>
MIME-Version: 1.0
In-Reply-To: <20191105090845.GP22393@meh.true.cz>
User-Agent: Mutt/1.11.3 (2019-02-01)
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 05, 2019 at 10:08:45AM +0100, Petr =C5=A0tetiar wrote:
> Stanislaw Gruszka <sgruszka@redhat.com> [2019-11-05 10:00:44]:
>=20
> Hi,
>=20
> > I provided the topic in the first reference of the commit at the top.
> > Should I do this anytime in the chenglog when a commit is referenced,
> > even if it's done already ?
>=20
>  ./scripts/checkpatch.pl 0001-Revert-mt76-mt76x0e-don-t-use-hw-encryption=
-for-MT76.patch
>  ERROR: Please use git commit description style 'commit <12+ chars of sha=
1> ("<title line>")' - ie: 'commit 7bd0650be63c ("mt76: dma: fix buffer unm=
ap with non-linear skbs")'
>  #8:=20
>  Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")

Okay, so I should add word 'commit' before HASH.

>  ERROR: Please use git commit description style 'commit <12+ chars of sha=
1> ("<title line>")' - ie: 'commit 7bd0650be63c ("mt76: dma: fix buffer unm=
ap with non-linear skbs")'
>  #14:=20
>  fixed by 7bd0650be63c , we can enable HW encryption back.

It's not clear if topic is need, but I can change it on the way.
BTW I hate checkpath.pl .

Stanislaw