Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (esa2.microchip.iphmx.com: domain of
  Ajay.Kathat@microchip.com designates 198.175.253.82 as
  permitted sender) identity=mailfrom;
  client-ip=198.175.253.82; receiver=esa2.microchip.iphmx.com;
  envelope-from="Ajay.Kathat@microchip.com";
  x-sender="Ajay.Kathat@microchip.com"; x-conformance=spf_only;
  x-record-type="v=spf1"; x-record-text="v=spf1 mx
  a:ushub1.microchip.com a:smtpout.microchip.com
  a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com
  include:servers.mcsv.net include:mktomail.com
  include:spf.protection.outlook.com ~all"
Received-SPF: None (esa2.microchip.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@email.microchip.com) identity=helo;
  client-ip=198.175.253.82; receiver=esa2.microchip.iphmx.com;
  envelope-from="Ajay.Kathat@microchip.com";
  x-sender="postmaster@email.microchip.com";
  x-conformance=spf_only
IronPort-SDR: WzMyZalH4CBeXPyVresdxG8bx9JSe59/pLbSSbSO9xfGKSH8Ow/K3EBRfMsAYU+WvpPa7+du+C
 Wv6F4vIiIJsVmeZlE4NTCsUbWTGHI9vHd8tgyVq61migdwgieSNzLsoWWFCPwcPNyNhtMU1dhB
 J1k0lqzPfGoumv0cZ4/sussMZDjJFlZwTe+uPV28wTRhd9NGlvXgjtGQkiy9CsQTsn6tSSUDJC
 +hXAPiCLmdQfFrb07/2aEg3J7pZGw5QDCJeRpiW+eU/9nOp0fMODnVgFL6X3MBuzwz4lu9efE8
 VO8=
From:   <Ajay.Kathat@microchip.com>
To:     <linux-wireless@vger.kernel.org>
CC:     <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>,
        <Adham.Abozaeid@microchip.com>, <johannes@sipsolutions.net>,
        <Ajay.Kathat@microchip.com>
Subject: [PATCH 1/6] staging: wilc1000: avoid 'bool' datatype in struct sent
 to firmware
Thread-Topic: [PATCH 1/6] staging: wilc1000: avoid 'bool' datatype in struct
 sent to firmware
Thread-Index: AQHVk76UV3bXW7Fx8UqiayEtu48wlA==
Date:   Tue, 5 Nov 2019 09:51:22 +0000
Message-ID: <20191105095058.24223-2-ajay.kathat@microchip.com>
References: <20191105095058.24223-1-ajay.kathat@microchip.com>
In-Reply-To: <20191105095058.24223-1-ajay.kathat@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [121.244.27.38]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7ed86c14-b9c7-4920-37f2-08d761d5b6ec
x-ms-traffictypediagnostic: BN6PR11MB1972:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN6PR11MB1972311E799E2CAA0055AA90E37E0@BN6PR11MB1972.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3968;
x-forefront-prvs: 0212BDE3BE
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(396003)(376002)(136003)(346002)(39860400002)(199004)(189003)(6486002)(6436002)(2616005)(36756003)(71190400001)(486006)(186003)(86362001)(76176011)(386003)(14454004)(5640700003)(52116002)(2501003)(6512007)(64756008)(99286004)(6916009)(66446008)(66476007)(66946007)(66556008)(71200400001)(2351001)(26005)(316002)(8936002)(8676002)(50226002)(81166006)(81156014)(102836004)(6506007)(4744005)(5660300002)(11346002)(1076003)(476003)(107886003)(54906003)(446003)(478600001)(25786009)(2906002)(7736002)(305945005)(4326008)(6116002)(3846002)(256004)(14444005)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR11MB1972;H:BN6PR11MB3985.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: U3PgRQSyURsXmV5bTc41vX325cz9xfluVpbNUBDwtZNPoT0hlJCsC2tPglMblNfeLSCER2dHmxvV/Nbcctaer0PzQtHqVhnC+DpHJRhGJPyXWdAgzSZl+OW6LBvWR5H3lVWd50jSGhpQgwYUoyIrh943BmPZoHZ6poNDA3ak37LsTiOiBXvOgJD5RIuJtDu5em83VZix2MwmdHcEq5A4SnGkfWnEoO2L+osw/RsieFYV9d4aBFlIImjWmPUqZ2YNKPB4S4f9s2+xPoTr4Ri3czCqKDMN27ihzrS0pM6oyNhyj9AcANBLX5bctmn34R3AvDArDdnaGEFQBvkHatD1OQW+wJGrhq5gfhqBqDQ9r/Z+g2RJ4wbfsTIiK8FqsXbG2PkFEJWMH0njzpyqveytNy1/4HMY0cWaAgyQJN8N9eGzlbJVIjKepoq67JfpYrJi
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ed86c14-b9c7-4920-37f2-08d761d5b6ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 09:51:22.5664
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nx0i9b9bgNRqdnawj0IHHBUvbN6saFdjbhG+x+o1f0neYnC+iOmWDc9O3ZbGUPjhH00Zd0Bls0hUeYXdZmRfEurDlJYGY0A/2DWdi+pGURY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1972
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Ajay Singh <ajay.kathat@microchip.com>

Use 'u8' instead of 'bool' datatype for struct element sent to firmware
because storage of bool datatype is not guaranteed.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/staging/wilc1000/wilc_hif.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_hif.c b/drivers/staging/wilc1000=
/wilc_hif.c
index e0a95c5cc0d5..59eb7600619b 100644
--- a/drivers/staging/wilc1000/wilc_hif.c
+++ b/drivers/staging/wilc1000/wilc_hif.c
@@ -32,7 +32,7 @@ struct wilc_op_mode {
 };
=20
 struct wilc_reg_frame {
-	bool reg;
+	u8 reg;
 	u8 reg_id;
 	__le16 frame_type;
 } __packed;
@@ -1784,7 +1784,9 @@ void wilc_frame_register(struct wilc_vif *vif, u16 fr=
ame_type, bool reg)
 	wid.val =3D (u8 *)&reg_frame;
=20
 	memset(&reg_frame, 0x0, sizeof(reg_frame));
-	reg_frame.reg =3D reg;
+
+	if (reg)
+		reg_frame.reg =3D 1;
=20
 	switch (frame_type) {
 	case IEEE80211_STYPE_ACTION:
--=20
2.22.0