Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5A10C61817
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     Petr =?utf-8?Q?=C5=A0tetiar?= <ynezz@true.cz>,
        linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
        Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>
Subject: Re: [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E"
References: <1572860780-2403-1-git-send-email-sgruszka@redhat.com>
        <87eeymd98m.fsf@tynnyri.adurom.net> <20191105090043.GB4422@redhat.com>
        <20191105090845.GP22393@meh.true.cz>
        <20191105095226.GC4422@redhat.com>
Date:   Tue, 05 Nov 2019 16:06:54 +0200
In-Reply-To: <20191105095226.GC4422@redhat.com> (Stanislaw Gruszka's message
        of "Tue, 5 Nov 2019 10:52:27 +0100")
Message-ID: <875zjy76yp.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Stanislaw Gruszka <sgruszka@redhat.com> writes:

> On Tue, Nov 05, 2019 at 10:08:45AM +0100, Petr =C5=A0tetiar wrote:
>> Stanislaw Gruszka <sgruszka@redhat.com> [2019-11-05 10:00:44]:
>>=20
>> Hi,
>>=20
>> > I provided the topic in the first reference of the commit at the top.
>> > Should I do this anytime in the chenglog when a commit is referenced,
>> > even if it's done already ?
>>=20
>>  ./scripts/checkpatch.pl
>> 0001-Revert-mt76-mt76x0e-don-t-use-hw-encryption-for-MT76.patch
>>  ERROR: Please use git commit description style 'commit <12+ chars
>> of sha1> ("<title line>")' - ie: 'commit 7bd0650be63c ("mt76: dma:
>> fix buffer unmap with non-linear skbs")'
>>  #8:=20
>>  Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")
>
> Okay, so I should add word 'commit' before HASH.
>
>>  ERROR: Please use git commit description style 'commit <12+ chars
>> of sha1> ("<title line>")' - ie: 'commit 7bd0650be63c ("mt76: dma:
>> fix buffer unmap with non-linear skbs")'
>>  #14:=20
>>  fixed by 7bd0650be63c , we can enable HW encryption back.
>
> It's not clear if topic is need, but I can change it on the way.
> BTW I hate checkpath.pl .

checkpatch gives only hints, it's perfectly ok to ignore warnings which
don't make sense. So no need to change anything in this case as you have
provided the title already earlier in the commit log.

--=20
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes