Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp927583ybx;
        Tue, 5 Nov 2019 07:40:48 -0800 (PST)
X-Google-Smtp-Source: APXvYqzsZz5YYGoj1Eid9TOr5CgCpPx8CcaX1UqhuHvG4nr5hInHtssFXQFloRcSpZWSIouv1mHe
X-Received: by 2002:a05:6402:502:: with SMTP id m2mr9017151edv.65.1572968448466;
        Tue, 05 Nov 2019 07:40:48 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1572968448; cv=none;
        d=google.com; s=arc-20160816;
        b=AIYbknf1avGvsy6jR0YhpDcnAiWjXVL+4V0ACEvdqiaZnuNY3GGlOr7PQKM1995LPG
         CmcOQi2N9jFaMyU4RBHOpTF70om097Pd+huApPmf9p0mR9Pob07leznaizigOJh+5a+7
         DzWysGS+osDWdOW/xg3+gqf/4NzQZlknHGYc6RjS1s177wPB8VFQ+xdp5sXekrw2ef/H
         akhhz2B6vVO154Sz7APRP2cp3wkGM61qgpNWRJbs5ZR5I8eeVWXIfmcXH6JvSUzzoSlT
         oPlqAfPiJKIYcZ92ZXJQAif5LEgcTIJwfgsQb8WoH83K94NGNs2KBQ8NHs/j4bsDD+xx
         64Yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature
         :from;
        bh=xAHDL82gecPwNtpcLYvqhCOsdaSg4bYDDeWK4hm2RNE=;
        b=zbKk3VOz0ocC6ThxUcdGB04Cdc94JYRbCVcyf0Lmr6ZOtnTIk02dQNIw/3eX/7IIA/
         nhLZUQgTvi6HF9EUoMPzGdsIeWgWoxK5EhFZxGHfBgqKNdRTJlLUhDptfa74pj5Erw2+
         O67i/5GRt2kUC5Hbk/CIiuNCkup6JppXAl0NYlV29TNiUYRwYZc+7wETGFlLYM+qd8UA
         1+Ee06fHLn8LSuFHAd8hH7wx/nCPQHiOy/Icd44/ggIALIh0Dz4Gg1XuzwTcA2gjocif
         2jpQ5KRhfgrg8uuZJdT5VgcB+zUBSHmkmTcKuIASSVNDSWSiTATvT5UESwB8Wcql3HWR
         xUdw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@toke.dk header.s=20161023 header.b=hB7nIsB5;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id g27si9342426ejc.219.2019.11.05.07.40.13;
        Tue, 05 Nov 2019 07:40:48 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@toke.dk header.s=20161023 header.b=hB7nIsB5;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389849AbfKEPkJ (ORCPT <rfc822;jupiter.hce@gmail.com>
        + 99 others); Tue, 5 Nov 2019 10:40:09 -0500
Received: from mail.toke.dk ([52.28.52.200]:35505 "EHLO mail.toke.dk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2389799AbfKEPkI (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 5 Nov 2019 10:40:08 -0500
X-Greylist: delayed 422 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Nov 2019 10:40:08 EST
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023;
        t=1572967984; bh=xAHDL82gecPwNtpcLYvqhCOsdaSg4bYDDeWK4hm2RNE=;
        h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
        b=hB7nIsB5fZ+6bljmrku1+t0+LeQzWR7H4d6EZeKDuKZQKcV4Vo3O7u3mHI0NAmAyR
         MWnIM6tnA/oyfnTW6V+3eEKBkqCeT/ipZPP/N0ew9sgVl/6XibHQks0x0Hz3tRcpat
         ExheoZc7nrPMCtDyvoOzxLwkZHRNUwIbiTRvrbSg1xTFgpYK2BVmBGPXkxxHpWxkWA
         XwesXWDTqqOC6L8yfFi4u1NdK+bPiy3CS/wMows7EBi8KPmqkYr3Rnnub11c8K2nv3
         8NBJ7R/W9+LeY0B/wcUzDMPezA6U9IyM0c7t+aq1XHIkz9jQAnsIaUK8R7FYbgJRYZ
         sovsHYS6c35YA==
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
Cc:     Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: fix ieee80211_txq_setup_flows() failure path
In-Reply-To: <20191105154110.1ccf7112ba5d.I0ba865792446d051867b33153be65ce6b063d98c@changeid>
References: <20191105154110.1ccf7112ba5d.I0ba865792446d051867b33153be65ce6b063d98c@changeid>
Date:   Tue, 05 Nov 2019 16:33:02 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87eeymjq35.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Johannes Berg <johannes@sipsolutions.net> writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> If ieee80211_txq_setup_flows() fails, we don't clean up LED
> state properly, leading to crashes later on, fix that.
>
> Fixes: dc8b274f0952 ("mac80211: Move up init of TXQs")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Oops, my bad; thanks for the fix!

Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>