Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp892222ybx; Wed, 6 Nov 2019 09:56:48 -0800 (PST) X-Google-Smtp-Source: APXvYqzo9q03UHqfibsTyrtxZBKIkBaTmafj28vtqBJpZ6GhjOHUMCBpISZTRNqddm7viN/86NVG X-Received: by 2002:a17:907:20f3:: with SMTP id rh19mr35328832ejb.289.1573063008204; Wed, 06 Nov 2019 09:56:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573063008; cv=none; d=google.com; s=arc-20160816; b=tIM7XIVhrsFV+R8/YegNwEZHLwQdruX1B8PvOpekhHNmbyfwXRGLMFUIhJiaGAqFVk vw+W5N9ecuGdIdpVVPCmIKPaQ9UymZlYDoJ7QhK8QaiOuLETwoIkwstIeNBkIiNmXK3s bNYIZPnwH8+msWs8TP642bRlfGvaVNGOzy2xNa1pE5qguVpRoGNxePVI/3CiywSWPcs6 HYZ/04l8WGZDLdf3ReQV6IKk4EIQujdVvg/ZG1esJibk2yZhj5qVdtRxIjUo9V6Dkind qi2/FTrKpaK5fTukzh48acYKT1ighZGmAx5/aVWXACrVgDzRBDl21wfeH0HV6qP0ft3v vyWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=yY2KnjsSdTfNAVtFwy8UwfACD42k0qIwyhJA7xetjh0=; b=kjxmHoyaL55qHsWG7R2oHdJm8vzfLJ0ycPLfT1uTStS5MVCfxThAkJipZ5t3EtioOU cLmF63O753skOWECd+R2RCDbdy4HwHHCyLtDx40pnnGjZekXxaB2im+mBuGBVda4sV5I fl8kOoJkDffig0gxBXMimR+1cbRHbo50yq5QMMpvdghgzRlmiZ8ex/rXC51Fal6XieA6 L2k6ctudmLF/RyiL3q/aTWa84/HgLSLIi13EQrgNiJ0QorhU7+HrA5CfAR8XyD3enbe1 AI3li62+Zmnerh+9Unnl+vo53G7bpJt6Kl75OH9m9u148sSAc6pvOVQ4sjAP64PoEo0q 8WmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=H7QV05bg; dkim=pass header.i=@codeaurora.org header.s=default header.b=S24sM0Ab; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z26si5221900ejb.223.2019.11.06.09.56.24; Wed, 06 Nov 2019 09:56:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=H7QV05bg; dkim=pass header.i=@codeaurora.org header.s=default header.b=S24sM0Ab; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbfKFRzz (ORCPT + 99 others); Wed, 6 Nov 2019 12:55:55 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35294 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbfKFRzz (ORCPT ); Wed, 6 Nov 2019 12:55:55 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0F79A60913; Wed, 6 Nov 2019 17:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573062954; bh=7Ve4JPk7jSnlevxFcGuL3VLvkJOYG00XEtK/6lbscmw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=H7QV05bgCgD/RYOB0qqYCDLrD1lKdVu2QsTskJpJvNdOsjTzLwR5+P0VXrCPvMxNu bgIjiE3y1yH0m9P7BEu/f9nbliVBBL0Pwzy6LKqasBmDvsOZWZ0Phj7goZjM7/kEg/ zpwAsrFdTvOFsJAsxPudRfnMCT2V11Jxfq+k5jQs= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A7A8860134; Wed, 6 Nov 2019 17:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573062953; bh=7Ve4JPk7jSnlevxFcGuL3VLvkJOYG00XEtK/6lbscmw=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=S24sM0Abo7IosRYQi2VvJGMuDNQCB8iijIPeIcEeTVK9siYt6vHdIyUJgblWyMqOo VjyvIEq5uoPOLjhaWDI10+k0KkkBDhu2Mdo2lVhwFDrGdlLP5dHWBVQDH0t7CUBDh8 5PHHtsDj/sgW4yfYJn80SY4XcNf8t3jGfp2Cqhjw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A7A8860134 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] rtw88: raise LPS threshold to 50, for less power consumption From: Kalle Valo In-Reply-To: <20191101051942.18730-1-yhchuang@realtek.com> References: <20191101051942.18730-1-yhchuang@realtek.com> To: Cc: , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191106175554.0F79A60913@smtp.codeaurora.org> Date: Wed, 6 Nov 2019 17:55:53 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org wrote: > From: Yan-Hsuan Chuang > > The LPS threshold was set to 2, means driver will leave LPS > mode if there is more than 2 frames TX/RX for every 2 seconds. > This makes driver enter/leave LPS frequently even if we just > "ping -i1" to the others. > > Apparently we do not want to leave LPS mode if there is only > some background traffics or web surfing. By experiment, set > this to 50 is a more reasonable value to lower the over all > power consumption. > > Signed-off-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. bf9840ccf8ef rtw88: raise LPS threshold to 50, for less power consumption -- https://patchwork.kernel.org/patch/11222327/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches