Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp894608ybx; Wed, 6 Nov 2019 09:59:09 -0800 (PST) X-Google-Smtp-Source: APXvYqwL6eQIRGp5jluuepDQVop4l1R4GNY4Pess4oXLIxPVJXo6DTSSBBSsnuskTkjU+M3wYBzl X-Received: by 2002:a17:906:9c1:: with SMTP id r1mr34766676eje.217.1573063149160; Wed, 06 Nov 2019 09:59:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573063149; cv=none; d=google.com; s=arc-20160816; b=QOot0nfpdYD9kQgnGEQ949970p4Sm80B92zEvoXMwPRLPTxBjc+UMf4nP/1H3Q3y4n Bhg2xlqu+p3yhRl7mbNsPlFiCS96RS8zTmiNKWprTiyoMHD24d3xsmg7zi/2d9U/bYAM A0lwJDnH8BWWDaCllqeYwciQ3Ey4k7JhENEQe/Jh41QknX9ReIRzzmnbPFFZbIeO/qfM t1nKRWLSDRorsPaksGhQpNdpVb3L0mUqf3fpOIY807dOfm8cClNb0FH2eJnaTCSwVVqk sBSMW82LYaBoZlDh3hPBCN4z43CL0BRbzqjnHteJGaAGjghu1qvxvnPmgXs4Unt+7oXr YvFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=ulF17p9OuQDWHRLUw7ga2XfBiijnsSthW3uMetwXvr8=; b=sgREufTWkrWDxOsgGRVRCBlvRjYWrkVvBXKzoGQZSE9J7IIRViLJKuqxRDkAwlYdxg n23jwXYTNTbEu17o3Kl/K9tjEqOVL/sUUC+lt3xOzhr9o7BvxBppRSSZLStQjpzExLTH DLrytzjn327eyAyJ2mTPFcN+W2jIsEEheLse4BhrXQ2/JFJ/75bXDr0e5CLUetAw7Q7s 5YGnTXdgj17aptoQlYbQi+0ADPDrqUNsRuEF7BmRgKNJHxZfjYaC2gmrQNJw1uSanvBJ xGT1yuABENimZdB4jRhKoyLssokNTPTak2UdBDVvdx0qU4JWXOpOKUw0nAl8oyNC3OT3 RMcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=KQdk3qrQ; dkim=pass header.i=@codeaurora.org header.s=default header.b=B8h1EXJE; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si13945731edx.365.2019.11.06.09.58.45; Wed, 06 Nov 2019 09:59:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=KQdk3qrQ; dkim=pass header.i=@codeaurora.org header.s=default header.b=B8h1EXJE; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732455AbfKFR6Z (ORCPT + 99 others); Wed, 6 Nov 2019 12:58:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37728 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732409AbfKFR6Z (ORCPT ); Wed, 6 Nov 2019 12:58:25 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 9A1586092C; Wed, 6 Nov 2019 17:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573063104; bh=BDkAFvmpP1pqvsT6Ptd54Z3W97BS25Pu4BZBWg081j8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=KQdk3qrQO/QFwJgsk9+7l9g23W/Dyz6tjw4vi3xfYgWpRMDOInHB/9XAMCfJIj6VJ As0qvMV3YmaKrpP0viilXBXmrUYq7CUyjjnoRLcVVmj7kPaqwQf70F+T0uL25AnRXa 5ikD125pZ+IX06AJI3LnLKBfMO6zvbqpjG06/ILY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1748260923; Wed, 6 Nov 2019 17:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573063102; bh=BDkAFvmpP1pqvsT6Ptd54Z3W97BS25Pu4BZBWg081j8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=B8h1EXJEVIHADkYdPp6KfUPQ4lDWOCsH2wc3lA+/WzIz16khnjBmzK2U9tVdl5uhv mMNPcd1v+Zt3VIgrdF+Y/NrFCa4zlcmn6bWqX9eSoyMCJATn9c/1WfQM0sFDCA9Kys W3EPkeefOufInrvc6zK+IVANCr1IIqtWAsM5GbqI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1748260923 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: fix potential NULL pointer access for firmware From: Kalle Valo In-Reply-To: <20191105090442.8378-1-yhchuang@realtek.com> References: <20191105090442.8378-1-yhchuang@realtek.com> To: Cc: , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191106175823.9A1586092C@smtp.codeaurora.org> Date: Wed, 6 Nov 2019 17:58:23 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org wrote: > From: Yan-Hsuan Chuang > > Driver could access a NULL firmware pointer if we don't > return here. > > Fixes: 5195b90426409 ("rtw88: avoid FW info flood") > Reported-by: kbuild test robot > Reported-by: Dan Carpenter > Signed-off-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. f530c1961af2 rtw88: fix potential NULL pointer access for firmware -- https://patchwork.kernel.org/patch/11227185/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches