Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp184476ybx; Wed, 6 Nov 2019 15:19:26 -0800 (PST) X-Google-Smtp-Source: APXvYqx1MLwLB1vrl0dQA6EC1ZHeCyP6aKVpwxlv2RbfZluCd3ukewAcYH94f9rd13zfIcT6QAfW X-Received: by 2002:aa7:cad5:: with SMTP id l21mr316935edt.131.1573082366754; Wed, 06 Nov 2019 15:19:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573082366; cv=none; d=google.com; s=arc-20160816; b=ZltL2iNf5N0TUXRwdDQUDPJauU7kC8i9OnoJ34LDPFusqip8QwWZlonXzakuk3pIgd SnA+di8EBlpt0LLE2fsbKbrCCzXGy7eyKGV74qivOQYPLOeVgIgxQEY1Grx+dYkjRDQ1 obqR7mALQajJytAfFWS1nP1SjM5mamy2AMLkbXaagEh/I35pzHmypEhDLY4PV169Om0a DG+XqDM8Hhdvf1MWlqQYpRDINQqhVfFQ7tL2TgWeIOPYhtJlhQrIjXpzRDvZU3if02Gd IZmrJNwystliSfvAJPyPzsopgMNS6lcLHyvpH+da3Q3Pt5sNO3F7cIeQLMF6DINElgtV riMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=PEEwQUwm/mtCk8pRNL9DiIeL71bqH+DtmpEDVuEb4+U=; b=YtqgJg2l1lHe2/GV94uCLE7ulzFEkvvaZZJH/dVxIDWUU7LNtTDqIFFe42ygpVYwqz /erLxFJloaWgyZeQhGN39pZXbaN5qyvSPgzqj3zXVXq/q6qwuQRSDdmDkjS5+rVfTybH 9rjFfwDcCQjARQJiwsx/yNm6bHjVTuJgzDj5X2ov0IrFWKHIbADY5ns95oZWpYpHNxIp XdWSYmDHqCxx6ujvZuG7Qh2sLzA0dPuradVv+t3BDVHX/YLTXFjl+81kZ6+4T66W/ptL AaV6oNUWaQgTs8IbrdCFkpo+MBphOcXTJX+iKZMZQsmDL7h4P/Nji+prKBaak59oPSGn Fjnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="neaEdK/p"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w32si43328edc.443.2019.11.06.15.18.57; Wed, 06 Nov 2019 15:19:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="neaEdK/p"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728065AbfKFXQ5 (ORCPT + 99 others); Wed, 6 Nov 2019 18:16:57 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45825 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727080AbfKFXQ5 (ORCPT ); Wed, 6 Nov 2019 18:16:57 -0500 Received: by mail-pg1-f193.google.com with SMTP id w11so144161pga.12; Wed, 06 Nov 2019 15:16:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=PEEwQUwm/mtCk8pRNL9DiIeL71bqH+DtmpEDVuEb4+U=; b=neaEdK/p5ar2I/xlFi4UuC6GILTW3Ks2guXTHYrzRYhhB5GJHWuYAmHteeS9QtXB38 vpLKCrRcrgDtne+sUmpqEZdWMZsLWa5Ssry3hRvPt+l5AUgBe8AMaGUA2siXrzL8Tt84 1eEY/yBnhOu6s1Y2lrffcUanSuXEiTYu3WyAp+so6Q1eXsx3jz708LQ6Mdq1uvSN8Vo7 JJGPN6spp11oAjv6GnrPV+rZqhqQj9G6EdHNJEhFT0mtH6Yql9JJ7SVvWG6TjRr7Umk6 c3P7nc+lnjR33OrTvZC29nfkOE2IsU3Xy0BVcshSmyKnj79HzS1hNJh1d56jWAFEUuZj ixbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PEEwQUwm/mtCk8pRNL9DiIeL71bqH+DtmpEDVuEb4+U=; b=RtgEvvQzJx/qMUL7ErGFfiO/PdxyuxaAuUBzXCZ5IplwODu5OCiLXB0h5/OPQjT/ZF uygXFgUMycmZDBBcjgY9TxY0RDtgwdiOIMSVLaLF4cbOdXQnBlLZMP5Vz3ysFIs13ckw 3bJkqsZ4xQl1pYfGqq1G06bkbgRRD6uVp/u7tFx3Ib7zmMgFO8ZXWQr4w5+wXDpUHOtS WbundO8wIkqSYqx+5NiaXzkKLZZNk/IUhD5ypkLnIurQpynz6FHyVaxXjrPqFP9wsz4R MpzLQ9fMgNM9u83liXKkkDFQd5bS4MlKeAJn8kTRY0Aq2FOG0YKpmnyDb8onOtWDp+RW x1LQ== X-Gm-Message-State: APjAAAXLc6ZlaGD5CX85kVpYmOCkdRSZQ3by+r2lLh4QJpIYtuEmaaGz 5k09WM3WoKBnx2OQb9Zf8Lo= X-Received: by 2002:a17:90a:cd03:: with SMTP id d3mr506186pju.137.1573082214787; Wed, 06 Nov 2019 15:16:54 -0800 (PST) Received: from aw-bldr-10.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d139sm49075pfd.162.2019.11.06.15.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2019 15:16:54 -0800 (PST) From: Jeffrey Hugo To: kvalo@codeaurora.org, davem@davemloft.net Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Jeffrey Hugo Subject: [PATCH] ath10k: Fix qmi init error handling Date: Wed, 6 Nov 2019 15:16:50 -0800 Message-Id: <20191106231650.1580-1-jeffrey.l.hugo@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org When ath10k_qmi_init() fails, the error handling does not free the irq resources, which causes an issue if we EPROBE_DEFER as we'll attempt to (re-)register irqs which are already registered. Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") Signed-off-by: Jeffrey Hugo --- drivers/net/wireless/ath/ath10k/snoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index fc15a0037f0e..f2a0b7aaad3b 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1729,7 +1729,7 @@ static int ath10k_snoc_probe(struct platform_device *pdev) ret = ath10k_qmi_init(ar, msa_size); if (ret) { ath10k_warn(ar, "failed to register wlfw qmi client: %d\n", ret); - goto err_core_destroy; + goto err_free_irq; } ath10k_dbg(ar, ATH10K_DBG_SNOC, "snoc probe\n"); -- 2.17.1