Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2156238ybx; Fri, 8 Nov 2019 00:28:19 -0800 (PST) X-Google-Smtp-Source: APXvYqzskYsdKBhKTfo5IzXSo5UmfLrErWb0LYEMwJ8fdRW9Y6XKr+ImryXMBag4tWKyLTR+5l6X X-Received: by 2002:a17:906:234e:: with SMTP id m14mr7226554eja.94.1573201699139; Fri, 08 Nov 2019 00:28:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573201699; cv=none; d=google.com; s=arc-20160816; b=wSh7m5KBkxKrDkN+drIK4fhjrKOrcc+UqfhSvY1ehbiGEDueALwlDwQRqNenGNwGKX BT0kLoro3eh4PUt0tEeXephRBmidD1S7ldWRSMugwcm7tK8W4JDENJ7OvrLeh6miGHye xEKQ+GRj/gInH2kDW2iMXJlOG5qiynAejjs7qSx9LkhuHA1awPAf2ThAbwjqgbF7LREA gDoytsXg+7gHujRo9/B3+Qx0AdStUi3D+FEulTHqLdA6RH9aMxl+5YZrt1rvCNXbYAV4 BhE4Oxv4P2TA594X/ahc30WAMZptNN+Jucbv0QvdETkFU4q6ZlEkhy92AFqDrNlSUYGZ 7sMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=r6C51f70Tdk8fd2ckN0T9XNCVRuJ5GZEfqRVPC1ndx0=; b=et8170LUf1j2sQYwO7myDCp5PKQ+uerFHyhb9tk+XLwXWprnxhni4quSwlwRNeFol5 UdKAIGBfqNZGt4HDHW6+MgDDl4hP8wxIQktA+QAUdo0SZl8EFJ60GEHOhu7lJ2FqttU0 LWrR3ySgucfMXXI/ObUgXUbdijGm6SjL8iaKIpBaKoqHaAkGrkwGlja3VFdVVhIYELcl 5vmX1lRyEW8fpOF9idsrSq/pjPuFoLm1NtX37DZZdGTXqddL6J5NBynTHBROwh/0nlh2 H3mtgjTuSUUtShLOzLTJQ50sqhJxBLaKO3aNTe7bOSllwnSeMX/vFWowSvxVrWeO5afO yyig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=bA8hFwKY; dkim=pass header.i=@codeaurora.org header.s=default header.b=LF4lyKEY; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dv23si3098244ejb.338.2019.11.08.00.27.44; Fri, 08 Nov 2019 00:28:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=bA8hFwKY; dkim=pass header.i=@codeaurora.org header.s=default header.b=LF4lyKEY; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbfKHI1Y (ORCPT + 99 others); Fri, 8 Nov 2019 03:27:24 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52968 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfKHI1X (ORCPT ); Fri, 8 Nov 2019 03:27:23 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 09A036087D; Fri, 8 Nov 2019 08:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573201643; bh=8dHJUXm+gkvbK8xd+vbY/KG2Jga+rtTuELCVO6DQqMA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=bA8hFwKYwGpCVEd8CeZCk1fDD3m2sLQPhTrZVtt/Elp8wLt/7FY+nLAhz7FvBx/9j AOCKQok1EF/FKlUIiXIKBQaZodQ0l2HGpjYV8NLGZmwucFgUToZ/7eV9J42tWmndmU AYgLJsbZHdnbcQrV3+bOq24zZtCcpsDUhtXKWU/E= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1B69C60300; Fri, 8 Nov 2019 08:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573201642; bh=8dHJUXm+gkvbK8xd+vbY/KG2Jga+rtTuELCVO6DQqMA=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=LF4lyKEYVW2JjiznWhJVnxnxGhYgfo+hmX3HSjncSCTonRDMux/DsHZ7Slie5RiMg p2khwdru2HysZvqNHJjklv/A7WrqNnzFwJOY8FUN6qg5/Zsajg6EfyYs6DMJ/Hh5I2 o10Pzrixzvfxed701XwN3HRZUcTqWUCvmt6Y/WWs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1B69C60300 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: signal completion even on firmware-request failure From: Kalle Valo In-Reply-To: <20191106213055.133424-1-briannorris@chromium.org> References: <20191106213055.133424-1-briannorris@chromium.org> To: Brian Norris Cc: , Yan-Hsuan Chuang , Brian Norris , Dan Carpenter User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191108082723.09A036087D@smtp.codeaurora.org> Date: Fri, 8 Nov 2019 08:27:23 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Brian Norris wrote: > Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever. > > Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware") > Cc: Dan Carpenter > Cc: Yan-Hsuan Chuang > Signed-off-by: Brian Norris > Acked-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. 21c60a28af58 rtw88: signal completion even on firmware-request failure -- https://patchwork.kernel.org/patch/11231189/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches